Sign upLogin

dockyard/dismissible_helpers

View on GitHub
Star

Showing 3 of 3 total issues

Method render_dismissible_helper has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def render_dismissible_helper(name, options = {}, &block)
    contents = block_given? ? capture(&block) : nil
    restorable = options.fetch(:restorable) { false }
    if restorable || !dismissed?(name)
      builder = restorable ? DismissibleHelpers::RestorableContentBuilder : DismissibleHelpers::ContentBuilder
Severity: Minor
Found in lib/dismissible_helpers/helpers/dismissible_helpers.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def create
    if respond_to?(:current_user) && current_user && current_user.respond_to?(:dismissed_helpers)
      current_user.dismissed_helpers += [ params[:helper] ]
      current_user.save!
    else
Severity: Minor
Found in lib/dismissible_helpers/controllers/dismissed_helpers.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method destroy has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def destroy
    Rails.logger.info "destroy '#{current_helper}'"
    if respond_to?(:current_user) && current_user && current_user.respond_to?(:dismissed_helpers)
      current_user.dismissed_helpers = current_user.dismissed_helpers.reject { |helper| helper == current_helper }
      current_user.save!
Severity: Minor
Found in lib/dismissible_helpers/controllers/dismissed_helpers.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language