Sign upLogin

dodecaphonic/balladina

View on GitHub
Star
lib/balladina_web/public/js/app.js

Summary

Maintainability
C
1 day
Test Coverage

File app.js has 275 lines of code (exceeds 250 allowed). Consider refactoring.
Open

var WEBSOCKET_URI   = "ws://" + location.hostname + ":7331";
var CLIENT_ID_PARTS = 6;

function generateClientId() {
  var randomNumbers   = new Uint8Array(CLIENT_ID_PARTS);
Severity: Minor
Found in lib/balladina_web/public/js/app.js - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        this.socket.onopen = function() {
      var message  = _.clone(Balladina.messages.PROMOTE_DATA);
      message.data = that.attributes.clientId;
      that.socket.send(JSON.stringify(message));
      that.set("ready", true);
    Severity: Major
    Found in lib/balladina_web/public/js/app.js and 1 other location - About 2 hrs to fix
    lib/balladina_web/public/js/app.js on lines 99..104

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 81.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        this.socket.onopen = function(event) {
      var message  = _.clone(Balladina.messages.PROMOTE_CONTROL);
      message.data = that.attributes.clientId;
      that.socket.send(JSON.stringify(message));
      that.set("ready", true);
    Severity: Major
    Found in lib/balladina_web/public/js/app.js and 1 other location - About 2 hrs to fix
    lib/balladina_web/public/js/app.js on lines 40..45

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 81.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      _startRecording: function() {
    this.attributes.control.set("recording", true);
    this.attributes.control.set({ signalRecording: true },
                                { silent: true});
  },
    Severity: Major
    Found in lib/balladina_web/public/js/app.js and 1 other location - About 1 hr to fix
    lib/balladina_web/public/js/app.js on lines 158..162

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      _stopRecording: function() {
    this.attributes.control.set("recording", false);
    this.attributes.control.set({ signalRecording: false },
                                { silent: true});
  },
    Severity: Major
    Found in lib/balladina_web/public/js/app.js and 1 other location - About 1 hr to fix
    lib/balladina_web/public/js/app.js on lines 152..156

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status