Sign upLogin

dolejska-daniel/riot-api-datadragon

View on GitHub
Star

Showing 5 of 32 total issues

DataDragonAPI has 84 functions (exceeds 20 allowed). Consider refactoring.
Open

class DataDragonAPI
{
    /**
     *   Settings constants.
     */
Severity: Major
Found in src/DataDragonAPI/DataDragonAPI.php - About 1 day to fix

    File DataDragonAPI.php has 688 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

/**
 * Copyright (C) 2016-2023  Daniel Dolejška
 *
    Severity: Major
    Found in src/DataDragonAPI/DataDragonAPI.php - About 1 day to fix

      Method getFromSprite has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public static function getFromSprite( string $source, int $x, int $y, int $w = 48, int $h = 48, array $attributes = [] ): Html
      Severity: Minor
      Found in src/DataDragonAPI/DataDragonAPI.php - About 45 mins to fix

        Method getStaticDataFileUrl has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public static function getStaticDataFileUrl( string $dataType, string $key = null, $locale = 'en_US', $version = null, string $fragment = null ): string
        Severity: Minor
        Found in src/DataDragonAPI/DataDragonAPI.php - About 35 mins to fix

          Function loadStaticData has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              protected static function loadStaticData( string $url, callable $postprocess = null, bool $data_from_postprocess = false ): array
    {
        // Try loading from cache
        $data = self::loadCachedStaticData($url);
        if ($data->isHit()) return $data->get();
          Severity: Minor
          Found in src/DataDragonAPI/DataDragonAPI.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language