Sign upLogin

doorkeeper-gem/doorkeeper

View on GitHub
Star

Showing 9 of 25 total issues

Similar blocks of code found in 5 locations. Consider refactoring.
Open

module Doorkeeper
  # Generates migration with which drops NOT NULL constraint and allows not
  # to bloat the database with redundant secret value.
  #
  class RemoveApplicationSecretNotNullConstraint < ::Rails::Generators::Base
Severity: Major
Found in lib/generators/doorkeeper/remove_applications_secret_not_null_constraint_generator.rb and 4 other locations - About 55 mins to fix
lib/generators/doorkeeper/application_owner_generator.rb on lines 6..30
lib/generators/doorkeeper/confidential_applications_generator.rb on lines 6..30
lib/generators/doorkeeper/migration_generator.rb on lines 6..29
lib/generators/doorkeeper/pkce_generator.rb on lines 6..30

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

module Doorkeeper
  # Generates migration with PKCE required database columns for
  # Doorkeeper tables.
  #
  class PkceGenerator < ::Rails::Generators::Base
Severity: Major
Found in lib/generators/doorkeeper/pkce_generator.rb and 4 other locations - About 55 mins to fix
lib/generators/doorkeeper/application_owner_generator.rb on lines 6..30
lib/generators/doorkeeper/confidential_applications_generator.rb on lines 6..30
lib/generators/doorkeeper/migration_generator.rb on lines 6..29
lib/generators/doorkeeper/remove_applications_secret_not_null_constraint_generator.rb on lines 6..30

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

module Doorkeeper
  # Generates migration to add reference to owner of the
  # Doorkeeper application.
  #
  class ApplicationOwnerGenerator < ::Rails::Generators::Base
Severity: Major
Found in lib/generators/doorkeeper/application_owner_generator.rb and 4 other locations - About 55 mins to fix
lib/generators/doorkeeper/confidential_applications_generator.rb on lines 6..30
lib/generators/doorkeeper/migration_generator.rb on lines 6..29
lib/generators/doorkeeper/pkce_generator.rb on lines 6..30
lib/generators/doorkeeper/remove_applications_secret_not_null_constraint_generator.rb on lines 6..30

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

module Doorkeeper
  # Copies main Doorkeeper migration into parent Rails application.
  #
  class MigrationGenerator < ::Rails::Generators::Base
    include ::Rails::Generators::Migration
Severity: Major
Found in lib/generators/doorkeeper/migration_generator.rb and 4 other locations - About 55 mins to fix
lib/generators/doorkeeper/application_owner_generator.rb on lines 6..30
lib/generators/doorkeeper/confidential_applications_generator.rb on lines 6..30
lib/generators/doorkeeper/pkce_generator.rb on lines 6..30
lib/generators/doorkeeper/remove_applications_secret_not_null_constraint_generator.rb on lines 6..30

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

module Doorkeeper
  # Generates migration to add confidential column to Doorkeeper
  # applications table.
  #
  class ConfidentialApplicationsGenerator < ::Rails::Generators::Base
Severity: Major
Found in lib/generators/doorkeeper/confidential_applications_generator.rb and 4 other locations - About 55 mins to fix
lib/generators/doorkeeper/application_owner_generator.rb on lines 6..30
lib/generators/doorkeeper/migration_generator.rb on lines 6..29
lib/generators/doorkeeper/pkce_generator.rb on lines 6..30
lib/generators/doorkeeper/remove_applications_secret_not_null_constraint_generator.rb on lines 6..30

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      def secret_generator
        generator_name = Doorkeeper.config.application_secret_generator
        generator = generator_name.constantize

        return generator if generator.respond_to?(:generate)
Severity: Minor
Found in lib/doorkeeper/orm/active_record/mixins/application.rb and 1 other location - About 35 mins to fix
lib/doorkeeper/models/access_token_mixin.rb on lines 503..511

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def token_generator
      generator_name = Doorkeeper.config.access_token_generator
      generator = generator_name.constantize

      return generator if generator.respond_to?(:generate)
Severity: Minor
Found in lib/doorkeeper/models/access_token_mixin.rb and 1 other location - About 35 mins to fix
lib/doorkeeper/orm/active_record/mixins/application.rb on lines 107..115

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        respond_to do |format|
          format.html { render :new }
          format.json do
            errors = @application.errors.full_messages
Severity: Minor
Found in app/controllers/doorkeeper/applications_controller.rb and 1 other location - About 15 mins to fix
app/controllers/doorkeeper/applications_controller.rb on lines 64..70

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        respond_to do |format|
          format.html { render :edit }
          format.json do
            errors = @application.errors.full_messages
Severity: Minor
Found in app/controllers/doorkeeper/applications_controller.rb and 1 other location - About 15 mins to fix
app/controllers/doorkeeper/applications_controller.rb on lines 42..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language