Sign upLogin

dopry/netlify-cms

View on GitHub
Star
src/components/Widgets/Markdown/MarkdownPreview/__tests__/renderer.spec.js

Summary

Maintainability
D
1 day
Test Coverage

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    describe('General', () => {
      it('should render markdown', () => {
        const value = `
# H1
Severity: Major
Found in src/components/Widgets/Markdown/MarkdownPreview/__tests__/renderer.spec.js and 3 other locations - About 2 hrs to fix
src/components/Widgets/Markdown/MarkdownPreview/__tests__/renderer.spec.js on lines 56..72
src/components/Widgets/Markdown/MarkdownPreview/__tests__/renderer.spec.js on lines 74..86
src/components/Widgets/Markdown/MarkdownPreview/__tests__/renderer.spec.js on lines 102..122

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    describe('Lists', () => {
      it('should render lists', () => {
        const value = `
1. ol item 1
1. ol item 2
Severity: Major
Found in src/components/Widgets/Markdown/MarkdownPreview/__tests__/renderer.spec.js and 3 other locations - About 2 hrs to fix
src/components/Widgets/Markdown/MarkdownPreview/__tests__/renderer.spec.js on lines 13..44
src/components/Widgets/Markdown/MarkdownPreview/__tests__/renderer.spec.js on lines 74..86
src/components/Widgets/Markdown/MarkdownPreview/__tests__/renderer.spec.js on lines 102..122

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    describe('HTML', () => {
      it('should render HTML as is when using Markdown', () => {
        const value = `
# Title
Severity: Major
Found in src/components/Widgets/Markdown/MarkdownPreview/__tests__/renderer.spec.js and 3 other locations - About 2 hrs to fix
src/components/Widgets/Markdown/MarkdownPreview/__tests__/renderer.spec.js on lines 13..44
src/components/Widgets/Markdown/MarkdownPreview/__tests__/renderer.spec.js on lines 56..72
src/components/Widgets/Markdown/MarkdownPreview/__tests__/renderer.spec.js on lines 74..86

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    describe('Links', () => {
      it('should render links', () => {
        const value = `
I get 10 times more traffic from [Google] [1] than from [Yahoo] [2] or [MSN] [3].
Severity: Major
Found in src/components/Widgets/Markdown/MarkdownPreview/__tests__/renderer.spec.js and 3 other locations - About 2 hrs to fix
src/components/Widgets/Markdown/MarkdownPreview/__tests__/renderer.spec.js on lines 13..44
src/components/Widgets/Markdown/MarkdownPreview/__tests__/renderer.spec.js on lines 56..72
src/components/Widgets/Markdown/MarkdownPreview/__tests__/renderer.spec.js on lines 102..122

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 87.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      it('should render code', () => {
        const value = 'Use the `printf()` function.';
        const component = shallow(<MarkdownPreview value={markdownToHtml(value)} />);
        expect(component.html()).toMatchSnapshot();
      });
Severity: Major
Found in src/components/Widgets/Markdown/MarkdownPreview/__tests__/renderer.spec.js and 2 other locations - About 1 hr to fix
src/components/Widgets/Markdown/MarkdownPreview/__tests__/renderer.spec.js on lines 95..99
src/components/Widgets/Markdown/MarkdownPreview/__tests__/renderer.spec.js on lines 126..130

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    it('should render HTML', () => {
      const value = '<p>Paragraph with <em>inline</em> element</p>';
      const component = shallow(<MarkdownPreview value={markdownToHtml(value)} />);
      expect(component.html()).toMatchSnapshot();
    });
Severity: Major
Found in src/components/Widgets/Markdown/MarkdownPreview/__tests__/renderer.spec.js and 2 other locations - About 1 hr to fix
src/components/Widgets/Markdown/MarkdownPreview/__tests__/renderer.spec.js on lines 89..93
src/components/Widgets/Markdown/MarkdownPreview/__tests__/renderer.spec.js on lines 95..99

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      it('should render code 2', () => {
        const value = '``There is a literal backtick (`) here.``';
        const component = shallow(<MarkdownPreview value={markdownToHtml(value)} />);
        expect(component.html()).toMatchSnapshot();
      });
Severity: Major
Found in src/components/Widgets/Markdown/MarkdownPreview/__tests__/renderer.spec.js and 2 other locations - About 1 hr to fix
src/components/Widgets/Markdown/MarkdownPreview/__tests__/renderer.spec.js on lines 89..93
src/components/Widgets/Markdown/MarkdownPreview/__tests__/renderer.spec.js on lines 126..130

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status