Sign upLogin

dopry/netlify-cms

View on GitHub
Star
src/components/Widgets/Markdown/serializers/__tests__/remarkAssertParents.spec.js

Summary

Maintainability
D
2 days
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    const output = u('root', [
      u('paragraph', [ u('text', 'Paragraph text.') ]),
      u('heading', { depth: 1 }, [ u('text', 'Heading text.') ]),
      u('code', 'someCode()'),
      u('blockquote', [ u('text', 'Quote text.') ]),
Severity: Major
Found in src/components/Widgets/Markdown/serializers/__tests__/remarkAssertParents.spec.js and 1 other location - About 3 hrs to fix
src/components/Widgets/Markdown/serializers/__tests__/remarkAssertParents.spec.js on lines 9..17

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 111.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      u('paragraph', [
        u('paragraph', [ u('text', 'Paragraph text.') ]),
        u('heading', { depth: 1 }, [ u('text', 'Heading text.') ]),
        u('code', 'someCode()'),
        u('blockquote', [ u('text', 'Quote text.') ]),
Severity: Major
Found in src/components/Widgets/Markdown/serializers/__tests__/remarkAssertParents.spec.js and 1 other location - About 3 hrs to fix
src/components/Widgets/Markdown/serializers/__tests__/remarkAssertParents.spec.js on lines 20..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 111.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  it('should remove blocks that are emptied as a result of denesting', () => {
    const input = u('root', [
      u('paragraph', [
        u('heading', { depth: 1 }, [ u('text', 'Heading text.') ]),
      ]),
Severity: Major
Found in src/components/Widgets/Markdown/serializers/__tests__/remarkAssertParents.spec.js and 2 other locations - About 3 hrs to fix
src/components/Widgets/Markdown/serializers/__tests__/remarkAssertParents.spec.js on lines 75..87
src/components/Widgets/Markdown/serializers/__tests__/remarkAssertParents.spec.js on lines 103..115

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  it('should handle assymetrical splits', () => {
    const input = u('root', [
      u('paragraph', [
        u('heading', { depth: 1 }, [ u('text', 'Heading text.') ]),
      ]),
Severity: Major
Found in src/components/Widgets/Markdown/serializers/__tests__/remarkAssertParents.spec.js and 2 other locations - About 3 hrs to fix
src/components/Widgets/Markdown/serializers/__tests__/remarkAssertParents.spec.js on lines 75..87
src/components/Widgets/Markdown/serializers/__tests__/remarkAssertParents.spec.js on lines 89..101

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  it('should remove blocks that are emptied as a result of denesting', () => {
    const input = u('root', [
      u('paragraph', [
        u('heading', { depth: 1 }, [ u('text', 'Heading text.') ]),
      ]),
Severity: Major
Found in src/components/Widgets/Markdown/serializers/__tests__/remarkAssertParents.spec.js and 2 other locations - About 3 hrs to fix
src/components/Widgets/Markdown/serializers/__tests__/remarkAssertParents.spec.js on lines 89..101
src/components/Widgets/Markdown/serializers/__tests__/remarkAssertParents.spec.js on lines 103..115

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    const input = u('root', [
      u('blockquote', [
        u('list', [
          u('listItem', [
            u('table', [
Severity: Major
Found in src/components/Widgets/Markdown/serializers/__tests__/remarkAssertParents.spec.js and 1 other location - About 2 hrs to fix
src/components/Widgets/Markdown/serializers/__tests__/remarkAssertParents.spec.js on lines 186..200

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    const output = u('root', [
      u('blockquote', [
        u('list', [
          u('listItem', [
            u('table', [
Severity: Major
Found in src/components/Widgets/Markdown/serializers/__tests__/remarkAssertParents.spec.js and 1 other location - About 2 hrs to fix
src/components/Widgets/Markdown/serializers/__tests__/remarkAssertParents.spec.js on lines 170..184

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 75.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status