dotcloud/docker

View on GitHub

Showing 1,468 of 1,914 total issues

File windows.go has 725 lines of code (exceeds 500 allowed). Consider refactoring.
Open

//go:build windows

// Shim for the Host Network Service (HNS) to manage networking for
// Windows Server containers and Hyper-V containers. This module
// is a basic libnetwork driver that passes all the calls to HNS
Severity: Minor
Found in libnetwork/drivers/windows/windows.go - About 7 hrs to fix

    File entry.pb.go has 714 lines of code (exceeds 500 allowed). Consider refactoring.
    Open

    // Code generated by protoc-gen-gogo. DO NOT EDIT.
    // source: entry.proto
    
    package logdriver
    
    
    Severity: Minor
    Found in api/types/plugins/logdriver/entry.pb.go - About 7 hrs to fix

      Method IPTable.ProgramChain has a Cognitive Complexity of 61 (exceeds 20 allowed). Consider refactoring.
      Open

      func (iptable IPTable) ProgramChain(c *ChainInfo, bridgeName string, hairpinMode, enable bool) error {
          if c.Name == "" {
              return errors.New("could not program chain, missing chain name")
          }
      
      
      Severity: Minor
      Found in libnetwork/iptables/iptables.go - About 7 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method ImageService.ImageDelete has a Cognitive Complexity of 61 (exceeds 20 allowed). Consider refactoring.
      Open

      func (i *ImageService) ImageDelete(ctx context.Context, imageRef string, force, prune bool) ([]imagetypes.DeleteResponse, error) {
          start := time.Now()
          records := []imagetypes.DeleteResponse{}
      
          img, err := i.GetImage(ctx, imageRef, backend.GetImageOpts{})
      Severity: Minor
      Found in daemon/images/image_delete.go - About 7 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method tarexporter.Load has a Cognitive Complexity of 60 (exceeds 20 allowed). Consider refactoring.
      Open

      func (l *tarexporter) Load(ctx context.Context, inTar io.ReadCloser, outStream io.Writer, quiet bool) (outErr error) {
          ctx, span := tracing.StartSpan(ctx, "tarexport.Load")
          defer span.End()
          defer func() {
              span.SetStatus(outErr)
      Severity: Minor
      Found in image/tarexport/load.go - About 6 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method PluginSpec.Unmarshal has 197 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (m *PluginSpec) Unmarshal(dAtA []byte) error {
          l := len(dAtA)
          iNdEx := 0
          for iNdEx < l {
              preIndex := iNdEx
      Severity: Major
      Found in api/types/swarm/runtime/plugin.pb.go - About 6 hrs to fix

        Method CompoundMessage_SimpleMessage.Unmarshal has a Cognitive Complexity of 59 (exceeds 20 allowed). Consider refactoring.
        Open

        func (m *CompoundMessage_SimpleMessage) Unmarshal(dAtA []byte) error {
            l := len(dAtA)
            iNdEx := 0
            for iNdEx < l {
                preIndex := iNdEx
        Severity: Minor
        Found in libnetwork/networkdb/networkdb.pb.go - About 6 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method CompoundMessage.Unmarshal has a Cognitive Complexity of 59 (exceeds 20 allowed). Consider refactoring.
        Open

        func (m *CompoundMessage) Unmarshal(dAtA []byte) error {
            l := len(dAtA)
            iNdEx := 0
            for iNdEx < l {
                preIndex := iNdEx
        Severity: Minor
        Found in libnetwork/networkdb/networkdb.pb.go - About 6 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method ImageService.ExportImage has a Cognitive Complexity of 59 (exceeds 20 allowed). Consider refactoring.
        Open

        func (i *ImageService) ExportImage(ctx context.Context, names []string, platform *ocispec.Platform, outStream io.Writer) error {
            pm := i.matchRequestedOrDefault(platforms.OnlyStrict, platform)
        
            opts := []archive.ExportOpt{
                archive.WithSkipNonDistributableBlobs(),
        Severity: Minor
        Found in daemon/containerd/image_exporter.go - About 6 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method ImageService.Images has 190 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (i *ImageService) Images(ctx context.Context, opts imagetypes.ListOptions) ([]*imagetypes.Summary, error) {
            if err := opts.Filters.Validate(acceptedImageFilterTags); err != nil {
                return nil, err
            }
        
        
        Severity: Major
        Found in daemon/images/image_list.go - About 6 hrs to fix

          Method ImageService.imageSummary has a Cognitive Complexity of 58 (exceeds 20 allowed). Consider refactoring.
          Open

          func (i *ImageService) imageSummary(ctx context.Context, img images.Image, platformMatcher platforms.MatchComparer,
              opts imagetypes.ListOptions, tagsByDigest map[digest.Digest][]string,
          ) (_ *imagetypes.Summary, allChainIDs []digest.Digest, _ error) {
              var manifestSummaries []imagetypes.ManifestSummary
          
          
          Severity: Minor
          Found in daemon/containerd/image_list.go - About 6 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method Cluster.UpdateService has a Cognitive Complexity of 58 (exceeds 20 allowed). Consider refactoring.
          Open

          func (c *Cluster) UpdateService(serviceIDOrName string, version uint64, spec swarm.ServiceSpec, flags types.ServiceUpdateOptions, queryRegistry bool) (*swarm.ServiceUpdateResponse, error) {
              var resp *swarm.ServiceUpdateResponse
          
              err := c.lockedManagerAction(func(ctx context.Context, state nodeState) error {
                  err := c.populateNetworkID(ctx, state.controlClient, &spec)
          Severity: Minor
          Found in daemon/cluster/services.go - About 6 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function ServiceSpecToGRPC has a Cognitive Complexity of 58 (exceeds 20 allowed). Consider refactoring.
          Open

          func ServiceSpecToGRPC(s types.ServiceSpec) (swarmapi.ServiceSpec, error) {
              name := s.Name
              if name == "" {
                  name = namesgenerator.GetRandomName(0)
              }
          Severity: Minor
          Found in daemon/cluster/convert/service.go - About 6 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method LogEntry.Unmarshal has 188 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func (m *LogEntry) Unmarshal(dAtA []byte) error {
              l := len(dAtA)
              iNdEx := 0
              for iNdEx < l {
                  preIndex := iNdEx
          Severity: Major
          Found in api/types/plugins/logdriver/entry.pb.go - About 6 hrs to fix

            Method Builder.Build has 186 lines of code (exceeds 50 allowed). Consider refactoring.
            Open

            func (b *Builder) Build(ctx context.Context, opt backend.BuildConfig) (*builder.Result, error) {
                if len(opt.Options.Outputs) > 1 {
                    return nil, errors.Errorf("multiple outputs not supported")
                }
            
            
            Severity: Major
            Found in builder/builder-next/builder.go - About 6 hrs to fix

              Method pushDescriptor.Upload has a Cognitive Complexity of 57 (exceeds 20 allowed). Consider refactoring.
              Open

              func (pd *pushDescriptor) Upload(ctx context.Context, progressOutput progress.Output) (distribution.Descriptor, error) {
                  // Skip foreign layers unless this registry allows nondistributable artifacts.
                  if !pd.endpoint.AllowNondistributableArtifacts {
                      if fs, ok := pd.layer.(distribution.Describable); ok {
                          if d := fs.Descriptor(); len(d.URLs) > 0 {
              Severity: Minor
              Found in distribution/push_v2.go - About 6 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method driver.CreateNetwork has a Cognitive Complexity of 57 (exceeds 20 allowed). Consider refactoring.
              Open

              func (d *driver) CreateNetwork(id string, option map[string]interface{}, nInfo driverapi.NetworkInfo, ipV4Data, ipV6Data []driverapi.IPAMData) error {
                  if _, err := d.getNetwork(id); err == nil {
                      return types.ForbiddenErrorf("network %s exists", id)
                  }
              
              
              Severity: Minor
              Found in libnetwork/drivers/windows/windows.go - About 6 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              File networkallocator.go has 684 lines of code (exceeds 500 allowed). Consider refactoring.
              Open

              package cnmallocator
              
              import (
                  "context"
                  "fmt"
              Severity: Minor
              Found in libnetwork/cnmallocator/networkallocator.go - About 6 hrs to fix

                Method BulkSyncMessage.Unmarshal has 184 lines of code (exceeds 50 allowed). Consider refactoring.
                Open

                func (m *BulkSyncMessage) Unmarshal(dAtA []byte) error {
                    l := len(dAtA)
                    iNdEx := 0
                    for iNdEx < l {
                        preIndex := iNdEx
                Severity: Major
                Found in libnetwork/networkdb/networkdb.pb.go - About 6 hrs to fix

                  Method Cluster.ServiceLogs has a Cognitive Complexity of 56 (exceeds 20 allowed). Consider refactoring.
                  Open

                  func (c *Cluster) ServiceLogs(ctx context.Context, selector *backend.LogSelector, config *container.LogsOptions) (<-chan *backend.LogMessage, error) {
                      c.mu.RLock()
                      defer c.mu.RUnlock()
                  
                      state := c.currentNodeState()
                  Severity: Minor
                  Found in daemon/cluster/services.go - About 6 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language