dougmoscrop/serverless-http

View on GitHub
lib/framework/get-framework.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function getFramework has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function getFramework(app) {
  if (app instanceof http.Server) {
    return request => {
      const response = new Response(request);
      app.emit('request', request, response)
Severity: Minor
Found in lib/framework/get-framework.js - About 2 hrs to fix

    Function getFramework has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    module.exports = function getFramework(app) {
      if (app instanceof http.Server) {
        return request => {
          const response = new Response(request);
          app.emit('request', request, response)
    Severity: Minor
    Found in lib/framework/get-framework.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

        return common(app);
    Severity: Major
    Found in lib/framework/get-framework.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return async request => {
            const { method, url, headers, body } = request;
      
            const res = await app.inject({ method, url, headers, payload: body })
      
      
      Severity: Major
      Found in lib/framework/get-framework.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return common((req, res) => {
              const { url, method, headers, body } = req;
              app.router.route({ url, method, headers, body }, res);
            });
        Severity: Major
        Found in lib/framework/get-framework.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return common((request, response) => {
                app._onRequest(request, response);
              });
          Severity: Major
          Found in lib/framework/get-framework.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return common(app._core._dispatch({
                  app
                }));
            Severity: Major
            Found in lib/framework/get-framework.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return common(app.main);
              Severity: Major
              Found in lib/framework/get-framework.js - About 30 mins to fix

                There are no issues that match your filters.

                Category
                Status