Sign upLogin

drapergem/draper

View on GitHub
Star

Showing 2 of 207 total issues

Class Decorator has 25 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Decorator
    include Draper::ViewHelpers
    include Draper::Compatibility::GlobalID if defined?(GlobalID)
    extend Draper::Delegation
Severity: Minor
Found in lib/draper/decorator.rb - About 2 hrs to fix

    Method decorator_class has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def decorator_class(called_on = self)
        prefix = respond_to?(:model_name) ? model_name : name
        decorator_name = "#{prefix}Decorator"
        decorator_name_constant = decorator_name.safe_constantize
        return decorator_name_constant unless decorator_name_constant.nil?
    Severity: Minor
    Found in lib/draper/decoratable.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language