Sign upLogin

drewish/rspec-rails-swagger

View on GitHub
Star

Showing 4 of 11 total issues

File request_builder_spec.rb has 265 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'swagger_helper'

RSpec.describe RSpec::Rails::Swagger::RequestBuilder do
  describe '#initialize' do
    it 'stores metadata and instance' do
Severity: Minor
Found in spec/rspec/rails/swagger/request_builder_spec.rb - About 2 hrs to fix

    Method response has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

              def response status_code, attributes = {}, &block
            attributes.symbolize_keys!

            validate_status_code! status_code
            validate_description! attributes[:description]
    Severity: Minor
    Found in lib/rspec/rails/swagger/helpers.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method response has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

              def response status_code, attributes = {}, &block
            attributes.symbolize_keys!

            validate_status_code! status_code
            validate_description! attributes[:description]
    Severity: Minor
    Found in lib/rspec/rails/swagger/helpers.rb - About 1 hr to fix

      Method parameter_values has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

              def parameter_values location
          values = parameters(location).
            map{ |_, p| p['$ref'] ? document.resolve_ref(p['$ref']) : p }.
            select{ |p| p[:required] || instance.respond_to?(p[:name]) }.
            map{ |p| [p[:name], instance.send(p[:name])] }
      Severity: Minor
      Found in lib/rspec/rails/swagger/request_builder.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language