drhenner/ror_ecommerce

View on GitHub
app/assets/javascripts/foundation/foundation.forms.js

Summary

Maintainability
F
4 days
Test Coverage

Function events has 147 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    events: function () {
      var self = this;

      $(this.scope)
        .on('click.fndtn.forms', 'form.custom span.custom.checkbox', function (e) {
Severity: Major
Found in app/assets/javascripts/foundation/foundation.forms.js - About 5 hrs to fix

    File foundation.forms.js has 401 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    (function ($, window, document, undefined) {
      'use strict';
    
      Foundation.libs.forms = {
        name : 'forms',
    Severity: Minor
    Found in app/assets/javascripts/foundation/foundation.forms.js - About 5 hrs to fix

      Function append_custom_select has 62 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          append_custom_select: function (idx, sel) {
              var self = Foundation.libs.forms,
                  $this = $(sel),
                  $customSelect = $this.next('div.custom.dropdown'),
                  $customList = $customSelect.find('ul'),
      Severity: Major
      Found in app/assets/javascripts/foundation/foundation.forms.js - About 2 hrs to fix

        Function refresh_custom_select has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            refresh_custom_select: function ($select, force_refresh) {
              var self = this;
              var maxWidth = 0,
                  $customSelect = $select.next(),
                  $options = $select.find('option'),
        Severity: Minor
        Found in app/assets/javascripts/foundation/foundation.forms.js - About 1 hr to fix

          Avoid deeply nested control flow statements.
          Open

                          if ($customRadio.length === 0) {
                            $customRadio = $associatedElement.add(this).siblings('span.custom.radio').first();
                          }
          Severity: Major
          Found in app/assets/javascripts/foundation/foundation.forms.js - About 45 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                      if (e.which === 38) {
                        var current = dropdown.find('li.selected'),
                            prev = current.prev(':not(.disabled)');
            
                        if (prev.length > 0) {
            Severity: Major
            Found in app/assets/javascripts/foundation/foundation.forms.js and 1 other location - About 4 hrs to fix
            app/assets/javascripts/foundation/foundation.forms.js on lines 212..221

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 117.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                      } else if (e.which === 40) {
                        var current = dropdown.find('li.selected'),
                            next = current.next(':not(.disabled)');
            
                        if (next.length > 0) {
            Severity: Major
            Found in app/assets/javascripts/foundation/foundation.forms.js and 1 other location - About 4 hrs to fix
            app/assets/javascripts/foundation/foundation.forms.js on lines 203..221

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 117.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                          if ($associatedElement.attr('type') === 'checkbox') {
                            e.preventDefault();
                            $customCheckbox = $(this).find('span.custom.checkbox');
                            //the checkbox might be outside after the label or inside of another element
                            if ($customCheckbox.length === 0) {
            Severity: Major
            Found in app/assets/javascripts/foundation/foundation.forms.js and 1 other location - About 2 hrs to fix
            app/assets/javascripts/foundation/foundation.forms.js on lines 89..97

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 93.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                          } else if ($associatedElement.attr('type') === 'radio') {
                            e.preventDefault();
                            $customRadio = $(this).find('span.custom.radio');
                            //the radio might be outside after the label or inside of another element
                            if ($customRadio.length === 0) {
            Severity: Major
            Found in app/assets/javascripts/foundation/foundation.forms.js and 1 other location - About 2 hrs to fix
            app/assets/javascripts/foundation/foundation.forms.js on lines 81..97

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 93.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                toggle_checkbox: function ($element) {
                  var $input = $element.prev(),
                      input = $input[0];
            
                  if (false === $input.is(':disabled')) {
            Severity: Major
            Found in app/assets/javascripts/foundation/foundation.forms.js and 1 other location - About 2 hrs to fix
            app/assets/javascripts/admin/jquery.customforms.js on lines 142..152

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 89.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        $this.closest('ul').find('li').each(function (index) {
                          if ($this[0] === this) {
                            selectedIndex = index;
                          }
                        });
            Severity: Major
            Found in app/assets/javascripts/foundation/foundation.forms.js and 1 other location - About 1 hr to fix
            app/assets/javascripts/admin/jquery.customforms.js on lines 248..253

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  $('form.custom input[type="radio"],[type="checkbox"]', $(this.scope))
                    .not('[data-customforms="disabled"]')
                    .not('.' + this.settings.disable_class)
                    .each(function(idx, sel){
                      forms.set_custom_markup(sel);
            Severity: Minor
            Found in app/assets/javascripts/foundation/foundation.forms.js and 1 other location - About 35 mins to fix
            app/assets/javascripts/foundation/foundation.forms.js on lines 49..52

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  $('form.custom select', $(this.scope))
                    .not('[data-customforms="disabled"]')
                    .not('.' + this.settings.disable_class)
                    .not('[multiple=multiple]')
            Severity: Minor
            Found in app/assets/javascripts/foundation/foundation.forms.js and 1 other location - About 35 mins to fix
            app/assets/javascripts/foundation/foundation.forms.js on lines 39..44

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  $(this.scope)
                    .on('click.fndtn.forms', 'form.custom span.custom.checkbox', function (e) {
                      e.preventDefault();
                      e.stopPropagation();
                      self.toggle_checkbox($(this));
            Severity: Minor
            Found in app/assets/javascripts/foundation/foundation.forms.js and 1 other location - About 30 mins to fix
            app/assets/javascripts/foundation/foundation.forms.js on lines 59..69

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status