drhenner/ror_ecommerce

View on GitHub
app/assets/javascripts/foundation/foundation.reveal.js

Summary

Maintainability
F
3 days
Test Coverage

File foundation.reveal.js has 285 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*jslint unparam: true, browser: true, indent: 2 */

;(function ($, window, document, undefined) {
  'use strict';

Severity: Minor
Found in app/assets/javascripts/foundation/foundation.reveal.js - About 2 hrs to fix

    Function events has 54 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        events : function () {
          var self = this;
    
          $(this.scope)
            .off('.fndtn.reveal')
    Severity: Major
    Found in app/assets/javascripts/foundation/foundation.reveal.js - About 2 hrs to fix

      Function show has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          show : function (el, css) {
            // is modal
            if (css) {
              if (el.parent('body').length === 0) {
                var placeholder = el.wrap('<div style="display: none;" />').parent();
      Severity: Minor
      Found in app/assets/javascripts/foundation/foundation.reveal.js - About 1 hr to fix

        Function open has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            open : function (target, ajax_settings) {
              if (target) {
                if (typeof target.selector !== 'undefined') {
                  var modal = $('#' + target.data('reveal-id'));
                } else {
        Severity: Minor
        Found in app/assets/javascripts/foundation/foundation.reveal.js - About 1 hr to fix

          Function hide has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              hide : function (el, css) {
                // is modal
                if (css) {
                  if (/pop/i.test(this.settings.animation)) {
                    var end_css = {
          Severity: Minor
          Found in app/assets/javascripts/foundation/foundation.reveal.js - About 1 hr to fix

            Avoid too many return statements within this function.
            Open

                  return el.show();
            Severity: Major
            Found in app/assets/javascripts/foundation/foundation.reveal.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return el.hide();
              Severity: Major
              Found in app/assets/javascripts/foundation/foundation.reveal.js - About 30 mins to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                          return this.delay(function () {
                            return el
                              .css(css)
                              .animate(end_css, this.settings.animationSpeed, 'linear', function () {
                                this.locked = false;
                Severity: Major
                Found in app/assets/javascripts/foundation/foundation.reveal.js and 1 other location - About 3 hrs to fix
                app/assets/javascripts/foundation/foundation.reveal.js on lines 232..240

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 110.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                          return this.delay(function () {
                            return el
                              .css(css)
                              .animate(end_css, this.settings.animationSpeed, 'linear', function () {
                                this.locked = false;
                Severity: Major
                Found in app/assets/javascripts/foundation/foundation.reveal.js and 1 other location - About 3 hrs to fix
                app/assets/javascripts/foundation/foundation.reveal.js on lines 246..254

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 110.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                          return this.delay(function () {
                            return el
                              .animate(end_css, this.settings.animationSpeed, 'linear', function () {
                                this.locked = false;
                                el.css(css).trigger('closed');
                Severity: Major
                Found in app/assets/javascripts/foundation/foundation.reveal.js and 1 other location - About 3 hrs to fix
                app/assets/javascripts/foundation/foundation.reveal.js on lines 277..284

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 110.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                          return this.delay(function () {
                            return el
                              .animate(end_css, this.settings.animationSpeed, 'linear', function () {
                                this.locked = false;
                                el.css(css).trigger('closed');
                Severity: Major
                Found in app/assets/javascripts/foundation/foundation.reveal.js and 1 other location - About 3 hrs to fix
                app/assets/javascripts/foundation/foundation.reveal.js on lines 290..297

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 110.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 3 locations. Consider refactoring.
                Open

                      if (typeof method === 'object') {
                        $.extend(true, this.settings, method);
                      } else if (typeof options !== 'undefined') {
                        $.extend(true, this.settings, options);
                      }
                Severity: Major
                Found in app/assets/javascripts/foundation/foundation.reveal.js and 2 other locations - About 1 hr to fix
                app/assets/javascripts/foundation/foundation.tooltips.js on lines 31..35
                app/assets/javascripts/foundation/foundation.topbar.js on lines 26..30

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 61.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      if (/fade/i.test(this.settings.animation)) {
                        return el.fadeOut(this.settings.animationSpeed / 2);
                      }
                Severity: Minor
                Found in app/assets/javascripts/foundation/foundation.reveal.js and 1 other location - About 40 mins to fix
                app/assets/javascripts/foundation/foundation.reveal.js on lines 261..263

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      if (/fade/i.test(this.settings.animation)) {
                        return el.fadeIn(this.settings.animationSpeed / 2);
                      }
                Severity: Minor
                Found in app/assets/javascripts/foundation/foundation.reveal.js and 1 other location - About 40 mins to fix
                app/assets/javascripts/foundation/foundation.reveal.js on lines 304..306

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status