drhenner/ror_ecommerce

View on GitHub
app/assets/javascripts/jqwizard/jquery.validate.js

Summary

Maintainability
F
3 days
Test Coverage

File jquery.validate.js has 905 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * jQuery validation plug-in 1.7
 *
 * http://bassistance.de/jquery-plugins/jquery-plugin-validation/
 * http://docs.jquery.com/Plugins/Validation
Severity: Major
Found in app/assets/javascripts/jqwizard/jquery.validate.js - About 2 days to fix

    Function validate has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        validate: function( options ) {
    
            // if nothing is selected, return nothing; can't chain anyway
            if (!this.length) {
                options && options.debug && window.console && console.warn( "nothing selected, can't validate, returning nothing" );
    Severity: Major
    Found in app/assets/javascripts/jqwizard/jquery.validate.js - About 2 hrs to fix

      Function normalizeRules has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          normalizeRules: function(rules, element) {
              // handle dependency check
              $.each(rules, function(prop, val) {
                  // ignore rule when param is explicitly false, eg. required:false
                  if (val === false) {
      Severity: Major
      Found in app/assets/javascripts/jqwizard/jquery.validate.js - About 2 hrs to fix

        Function remote has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                remote: function(value, element, param) {
                    if ( this.optional(element) )
                        return "dependency-mismatch";
                    
                    var previous = this.previousValue(element);
        Severity: Minor
        Found in app/assets/javascripts/jqwizard/jquery.validate.js - About 1 hr to fix

          Function rules has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              rules: function(command, argument) {
                  var element = this[0];
                  
                  if (command) {
                      var settings = $.data(element.form, 'validator').settings;
          Severity: Minor
          Found in app/assets/javascripts/jqwizard/jquery.validate.js - About 1 hr to fix

            Function check has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    check: function( element ) {
                        element = this.clean( element );
                        
                        // if radio/checkbox, validate first element in group instead
                        if (this.checkable(element)) {
            Severity: Minor
            Found in app/assets/javascripts/jqwizard/jquery.validate.js - About 1 hr to fix

              Function init has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      init: function() {
                          this.labelContainer = $(this.settings.errorLabelContainer);
                          this.errorContext = this.labelContainer.length && this.labelContainer || $(this.currentForm);
                          this.containers = $(this.settings.errorContainer).add( this.settings.errorLabelContainer );
                          this.submitted = {};
              Severity: Minor
              Found in app/assets/javascripts/jqwizard/jquery.validate.js - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        minlength: function(value, element, param) {
                            return this.optional(element) || this.getLength($.trim(value), element) >= param;
                        },
                Severity: Minor
                Found in app/assets/javascripts/jqwizard/jquery.validate.js and 1 other location - About 50 mins to fix
                app/assets/javascripts/jqwizard/jquery.validate.js on lines 973..975

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 51.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        maxlength: function(value, element, param) {
                            return this.optional(element) || this.getLength($.trim(value), element) <= param;
                        },
                Severity: Minor
                Found in app/assets/javascripts/jqwizard/jquery.validate.js and 1 other location - About 50 mins to fix
                app/assets/javascripts/jqwizard/jquery.validate.js on lines 968..970

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 51.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status