drhenner/ror_ecommerce

View on GitHub

Showing 203 of 346 total issues

Avoid too many return statements within this function.
Open

      return zepto.Z(dom, selector)
Severity: Major
Found in app/assets/javascripts/zepto.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                  return false;
    Severity: Major
    Found in app/assets/javascripts/markitup/jquery.markitup.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return this;
      Severity: Major
      Found in app/assets/javascripts/jqwizard/jquery.form.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return el.value;
        Severity: Major
        Found in app/assets/javascripts/jqwizard/jquery.form.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                        return false;
          Severity: Major
          Found in app/assets/javascripts/markitup/jquery.markitup.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return this;
            Severity: Major
            Found in app/assets/javascripts/jqwizard/jquery.form.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                            return options.onTab.keepDefault;
              Severity: Major
              Found in app/assets/javascripts/markitup/jquery.markitup.js - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                      return admin_shopping_checkout_shipping_methods_url()
                Severity: Major
                Found in app/controllers/admin/shopping/checkout/base_controller.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                        return nil #admin_shopping_carts_url()
                  Severity: Major
                  Found in app/controllers/admin/shopping/checkout/base_controller.rb - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                          return shopping_shipping_methods_url()
                    Severity: Major
                    Found in app/controllers/shopping/base_controller.rb - About 30 mins to fix

                      Method update_cim_profile has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def update_cim_profile
                          if not self.customer_cim_id
                            return false
                          end
                          if self.email_changed? || self.first_name_changed? || self.last_name_changed?
                      Severity: Minor
                      Found in app/models/concerns/user_cim.rb - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method confirmation has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def confirmation
                          @tab = 'confirmation'
                          if session[:last_order].present? && session[:last_order] == params[:id]
                            session[:last_order] = nil
                            @order = Order.includes({order_items: :variant}).find_by(number: params[:id])
                      Severity: Minor
                      Found in app/controllers/shopping/orders_controller.rb - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method show has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def show
                          authorize! :create_orders, current_user
                      
                          @order = find_or_create_order
                          #@order = session_admin_cart.add_items_to_checkout(order) # need here because items can also be removed
                      Severity: Minor
                      Found in app/controllers/admin/shopping/checkout/orders_controller.rb - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method update has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def update
                          if session_cart.update_attributes(allowed_params)
                            if params[:commit] && params[:commit] == "checkout"
                              redirect_to( checkout_shopping_order_url('checkout'))
                            else
                      Severity: Minor
                      Found in app/controllers/shopping/cart_items_controller.rb - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method next_admin_order_form has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def next_admin_order_form()
                           # if cart is empty
                          if !session_admin_cart.customer_id
                            return admin_shopping_users_url
                          elsif !session_admin_cart.shopping_cart_items
                      Severity: Minor
                      Found in app/controllers/admin/shopping/checkout/base_controller.rb - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method fulfillment_grid has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def self.fulfillment_grid(params = {})
                          grid = Order.includes([:user]).where({ :orders => {:shipped => false }} ).where("orders.completed_at IS NOT NULL")
                          grid = grid.where({:active => true })                     unless  params[:show_all].present? && params[:show_all] == 'true'
                          grid = grid.where("orders.number LIKE ?", "#{params[:number]}%")  if params[:number].present?
                          grid = grid.where("orders.shipped = ?", true)                     if (params[:shipped].present? && params[:shipped] == 'true')
                      Severity: Minor
                      Found in app/models/order.rb - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method merge_with_previous_cart! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def merge_with_previous_cart!
                          if user_id && previous_cart
                            current_items = cart_items.map(&:variant_id)
                            previous_cart.cart_items.each do |item|
                              self.add_variant(item.variant_id, item.user, item.quantity) unless current_items.include?(item.variant_id)
                      Severity: Minor
                      Found in app/models/cart.rb - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method add_variant has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def add_variant(variant_id, customer, qty = 1, cart_item_type_id = ItemType::SHOPPING_CART_ID, admin_purchase = false)
                          items = shopping_cart_items.where(variant_id: variant_id).to_a
                          variant = Variant.find_by(id: variant_id)
                          quantity_to_purchase = variant.quantity_purchaseable_if_user_wants(qty.to_i, admin_purchase)
                          if admin_purchase && (quantity_to_purchase > 0)
                      Severity: Minor
                      Found in app/models/cart.rb - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method next_wizard_form has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def next_wizard_form
                          if !session[:product_wizard]
                            reset_product_wizard
                            admin_merchandise_wizards_brands_url
                          elsif !session[:product_wizard][:brand_id]
                      Severity: Minor
                      Found in app/controllers/admin/merchandise/wizards/base_controller.rb - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method inactivate= has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def inactivate=(val)
                          return unless val.present?
                          if val.to_s == '1' || val.to_s == 'true'
                            self.deleted_at ||= Time.zone.now
                          else
                      Severity: Minor
                      Found in app/models/variant.rb - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language