Showing 203 of 346 total issues
Avoid too many return statements within this function. Open
return el.show();Avoid too many return statements within this function. Open
return this;Avoid too many return statements within this function. Open
return false;Avoid too many return statements within this function. Open
return el.value;Avoid too many return statements within this function. Open
return this;Avoid too many return statements within this function. Open
return false;Avoid too many return statements within this function. Open
return options.onTab.keepDefault;Avoid too many return statements within this method. Open
return nil #admin_shopping_carts_url()Avoid too many return statements within this method. Open
return admin_shopping_checkout_shipping_methods_url()Avoid too many return statements within this method. Open
return shopping_shipping_methods_url()Method update_cim_profile has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def update_cim_profile
if not self.customer_cim_id
return false
end
if self.email_changed? || self.first_name_changed? || self.last_name_changed?- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method next_admin_order_form has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def next_admin_order_form()
# if cart is empty
if !session_admin_cart.customer_id
return admin_shopping_users_url
elsif !session_admin_cart.shopping_cart_items- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method find_or_create_order has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def find_or_create_order
return @session_admin_order if @session_admin_order
if session[:order_admin_id]
@session_admin_order = checkout_user.orders.include_checkout_objects.find_by_id(session[:order_admin_id])
create_order if !@session_admin_order || !@session_admin_order.in_progress?- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method next_wizard_form has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def next_wizard_form
if !session[:product_wizard]
reset_product_wizard
admin_merchandise_wizards_brands_url
elsif !session[:product_wizard][:brand_id]- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method inactivate= has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def inactivate=(val)
return unless val.present?
if val.to_s == '1' || val.to_s == 'true'
self.deleted_at ||= Time.zone.now
else- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method confirmation has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def confirmation
@tab = 'confirmation'
if session[:last_order].present? && session[:last_order] == params[:id]
session[:last_order] = nil
@order = Order.includes({order_items: :variant}).find_by(number: params[:id])- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method add_variant has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def add_variant(variant_id, customer, qty = 1, cart_item_type_id = ItemType::SHOPPING_CART_ID, admin_purchase = false)
items = shopping_cart_items.where(variant_id: variant_id).to_a
variant = Variant.find_by(id: variant_id)
quantity_to_purchase = variant.quantity_purchaseable_if_user_wants(qty.to_i, admin_purchase)
if admin_purchase && (quantity_to_purchase > 0)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method merge_with_previous_cart! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def merge_with_previous_cart!
if user_id && previous_cart
current_items = cart_items.map(&:variant_id)
previous_cart.cart_items.each do |item|
self.add_variant(item.variant_id, item.user, item.quantity) unless current_items.include?(item.variant_id)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method sortable has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def sortable(column, title = nil)
title ||= column.titleize
css_class = column == sort_column ? "current #{sort_direction}" : nil
direction = column == sort_column && sort_direction == "asc" ? "desc" : "asc"
link_to title, {:sort => column, :direction => direction}, {:class => css_class}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method update has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def update
if session_cart.update_attributes(allowed_params)
if params[:commit] && params[:commit] == "checkout"
redirect_to( checkout_shopping_order_url('checkout'))
else- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"