Sign upLogin

driver733/VK-Uploader

View on GitHub
Star

Showing 11 of 51 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        while (iter < audios.size()) {
            final int to;
            if (audios.size() < iter + WallPostsMusicAlbum.AUDIOS_IN_REQ) {
                to = audios.size() - iter;
            } else {
Severity: Major
Found in src/main/java/com/driver733/vkuploader/wallpost/wallposts/WallPostsMusicAlbum.java and 1 other location - About 1 hr to fix
src/main/java/com/driver733/vkuploader/wallpost/wallposts/WallPostsPhotoAlbum.java on lines 163..179

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        while (iter < photos.size()) {
            final int to;
            if (photos.size() < iter + WallPostsPhotoAlbum.PHOTOS_IN_REQ) {
                to = photos.size() - iter;
            } else {
Severity: Major
Found in src/main/java/com/driver733/vkuploader/wallpost/wallposts/WallPostsPhotoAlbum.java and 1 other location - About 1 hr to fix
src/main/java/com/driver733/vkuploader/wallpost/wallposts/WallPostsMusicAlbum.java on lines 180..196

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        for (final Path file : audios) {
            if (
                !this.props.containsKey(
                    file.getFileName().toString()
                )
Severity: Minor
Found in src/main/java/com/driver733/vkuploader/media/AudiosNonProcessed.java and 1 other location - About 55 mins to fix
src/main/java/com/driver733/vkuploader/media/photo/MediaPhotosNonProcessed.java on lines 86..101

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        for (final Path file : photos) {
            if (
                !this.props.containsKey(
                    file.getFileName().toString()
                )
Severity: Minor
Found in src/main/java/com/driver733/vkuploader/media/photo/MediaPhotosNonProcessed.java and 1 other location - About 55 mins to fix
src/main/java/com/driver733/vkuploader/media/AudiosNonProcessed.java on lines 79..93

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

    @Override
    public List<AbstractQueryBuilder<AudioAddQuery, Integer>> upload()
        throws Exception {
        final List<AbstractQueryBuilder<AudioAddQuery, Integer>> list =
            new ArrayList<>(
Severity: Minor
Found in src/main/java/com/driver733/vkuploader/wallpost/attachment/AttachmentAudioWithProps.java and 2 other locations - About 35 mins to fix
src/main/java/com/driver733/vkuploader/wallpost/attachment/AttachmentAudio.java on lines 95..108
src/main/java/com/driver733/vkuploader/wallpost/attachment/AttachmentCachedAudio.java on lines 118..130

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

    @Override
    public List<AbstractQueryBuilder<AudioAddQuery, Integer>> upload()
        throws Exception {
        final List<AbstractQueryBuilder<AudioAddQuery, Integer>> list = new ArrayList<>(
            this.audios.size()
Severity: Minor
Found in src/main/java/com/driver733/vkuploader/wallpost/attachment/AttachmentCachedAudio.java and 2 other locations - About 35 mins to fix
src/main/java/com/driver733/vkuploader/wallpost/attachment/AttachmentAudio.java on lines 95..108
src/main/java/com/driver733/vkuploader/wallpost/attachment/AttachmentAudioWithProps.java on lines 107..121

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

    @Override
    public List<AbstractQueryBuilder<AudioAddQuery, Integer>> upload()
        throws Exception {
        final List<AbstractQueryBuilder<AudioAddQuery, Integer>> list = new ArrayList<>(
            this.audios.size()
Severity: Minor
Found in src/main/java/com/driver733/vkuploader/wallpost/attachment/AttachmentAudio.java and 2 other locations - About 35 mins to fix
src/main/java/com/driver733/vkuploader/wallpost/attachment/AttachmentAudioWithProps.java on lines 107..121
src/main/java/com/driver733/vkuploader/wallpost/attachment/AttachmentCachedAudio.java on lines 118..130

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            if (audios.size() < from + WallPostsMusicAlbum.AUDIOS_IN_POST) {
                to = audios.size();
            } else {
                to = from + WallPostsMusicAlbum.AUDIOS_IN_POST;
            }
Severity: Minor
Found in src/main/java/com/driver733/vkuploader/wallpost/wallposts/WallPostsMusicAlbum.java and 1 other location - About 35 mins to fix
src/main/java/com/driver733/vkuploader/wallpost/wallposts/WallPostsPhotoAlbum.java on lines 239..243

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            if (photos.size() < from + WallPostsPhotoAlbum.PHOTOS_IN_POST) {
                to = photos.size();
            } else {
                to = from + WallPostsPhotoAlbum.PHOTOS_IN_POST;
            }
Severity: Minor
Found in src/main/java/com/driver733/vkuploader/wallpost/wallposts/WallPostsPhotoAlbum.java and 1 other location - About 35 mins to fix
src/main/java/com/driver733/vkuploader/wallpost/wallposts/WallPostsMusicAlbum.java on lines 271..275

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            this.properties.with(
                audio.getFileName().toString(),
                new StringBuilder(
                    this.properties.property(
                        audio.getFileName()
Severity: Minor
Found in src/main/java/com/driver733/vkuploader/wallpost/wallposts/WallPostsRandom.java and 1 other location - About 30 mins to fix
src/main/java/com/driver733/vkuploader/wallpost/wallposts/WallPostsMusicAlbum.java on lines 212..225

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            this.properties.with(
                audio.getFileName().toString(),
                new StringBuilder(
                    this.properties.property(
                        audio
Severity: Minor
Found in src/main/java/com/driver733/vkuploader/wallpost/wallposts/WallPostsMusicAlbum.java and 1 other location - About 30 mins to fix
src/main/java/com/driver733/vkuploader/wallpost/wallposts/WallPostsRandom.java on lines 326..339

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language