Showing 4 of 4 total issues
Method parse_options
has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def parse_options(args)
options = {}
option_parser = OptionParser.new do |opts|
opts.banner = "Usage: #{File.basename $0} [options]"
opts.version = VERSION
Method get_module_metadata_with_dependencies
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def get_module_metadata_with_dependencies(author, name, version)
modules_to_search = [ OpenStruct.new(:author => author, :name => name, :version => version) ]
already_searched_modules = []
Method get_module_metadata_with_dependencies
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
Open
def get_module_metadata_with_dependencies(author, name, version)
modules_to_search = [ OpenStruct.new(:author => author, :name => name, :version => version) ]
already_searched_modules = []
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method normalize
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
def self.normalize(uri_string)
begin
url = URI.parse(uri_string)
rescue URI::InvalidURIError => e
raise PuppetLibrary::ExpectedError, "Invalid URL '#{uri_string}': #{e.message}"
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"