Sign upLogin

dschnare/signalsjs

View on GitHub
Star

Showing 3 of 3 total issues

Function signal has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

function signal(name) {
  var handlers = [], connections = [],
    isEmitting = false, isPendingDisconnectAll = false;

  name = String(name || '') || 'Unknown';
Severity: Minor
Found in lib/signal.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function signal has 106 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function signal(name) {
  var handlers = [], connections = [],
    isEmitting = false, isPendingDisconnectAll = false;

  name = String(name || '') || 'Unknown';
Severity: Major
Found in lib/signal.js - About 4 hrs to fix

    Function connect has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      s.connect = function (handler, thisObj, priority) {
    if (!isNaN(thisObj)) {
      priority = thisObj;
      thisObj = undefined;
    }
    Severity: Minor
    Found in lib/signal.js - About 1 hr to fix
      Severity
      Category
      Status
      Source
      Language