Sign upLogin

dsd-meetme/frontend

View on GitHub
Star
app/components/user/recovery/urstController.js

Summary

Maintainability
C
1 day
Test Coverage

Function controller has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    var controller = function ($scope, $routeParams, dataPublisher, mixedContentToArray, configService) {
        var apiDomain = configService.apiDomain;
        var c = this;
        c.success = false;
        c.invalidFields = {
Severity: Major
Found in app/components/user/recovery/urstController.js - About 2 hrs to fix

    Function reset has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            c.reset = function () {
            var form = $scope.resetForm;
            c.errors = [];
            c.invalidFields.emailReq = form.email.$error.required;
            c.invalidFields.emailVal = form.email.$error.email;
    Severity: Minor
    Found in app/components/user/recovery/urstController.js - About 1 hr to fix

      Function controller has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          var controller = function ($scope, $routeParams, dataPublisher, mixedContentToArray, configService) {
      Severity: Minor
      Found in app/components/user/recovery/urstController.js - About 35 mins to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                        dataPublisher.publish(apiDomain + '/employee/password/reset', {
                    company: c.company,
                    email: c.email,
                    password: c.password,
                    password_confirmation: c.password,
        Severity: Major
        Found in app/components/user/recovery/urstController.js and 1 other location - About 4 hrs to fix
        app/components/user/recovery/urecController.js on lines 28..43

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 133.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                c.confirmPopup = {
            show: function () {
                jQuery("#authorizationPopup").modal('show');
            },
            hide: function () {
        Severity: Major
        Found in app/components/user/recovery/urstController.js and 3 other locations - About 1 hr to fix
        app/components/organization/recovery/orecController.js on lines 13..20
        app/components/organization/recovery/orstController.js on lines 15..22
        app/components/user/recovery/urecController.js on lines 12..19

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status