Sign upLogin

dsi-icl/optimise

View on GitHub
Star
packages/optimise-core/src/controllers/ceController.js

Summary

Maintainability
F
3 days
Test Coverage

Function createCe has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

    static createCe({ body, user }, res) {
        if ((body.hasOwnProperty('visitId') || body.hasOwnProperty('patient')) && body.hasOwnProperty('dateStartDate') && body.hasOwnProperty('type') &&
            typeof body.visitId === 'number' && typeof body.dateStartDate === 'string' && typeof body.type === 'number') {
            const momentStart = moment(body.dateStartDate, moment.ISO_8601);
            if (!momentStart.isValid()) {
Severity: Minor
Found in packages/optimise-core/src/controllers/ceController.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function createCe has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    static createCe({ body, user }, res) {
        if ((body.hasOwnProperty('visitId') || body.hasOwnProperty('patient')) && body.hasOwnProperty('dateStartDate') && body.hasOwnProperty('type') &&
            typeof body.visitId === 'number' && typeof body.dateStartDate === 'string' && typeof body.type === 'number') {
            const momentStart = moment(body.dateStartDate, moment.ISO_8601);
            if (!momentStart.isValid()) {
Severity: Minor
Found in packages/optimise-core/src/controllers/ceController.js - About 1 hr to fix

    Function updateCe has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        static updateCe({ body, user }, res) {
        if (!body.hasOwnProperty('id')) {
            res.status(400).json(ErrorHelper(message.userError.MISSINGARGUMENT));
            return;
        }
    Severity: Minor
    Found in packages/optimise-core/src/controllers/ceController.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function updateCe has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        static updateCe({ body, user }, res) {
        if (!body.hasOwnProperty('id')) {
            res.status(400).json(ErrorHelper(message.userError.MISSINGARGUMENT));
            return;
        }
    Severity: Minor
    Found in packages/optimise-core/src/controllers/ceController.js - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

              if ((body.hasOwnProperty('visitId') || body.hasOwnProperty('patient')) && body.hasOwnProperty('dateStartDate') && body.hasOwnProperty('type') &&
            typeof body.visitId === 'number' && typeof body.dateStartDate === 'string' && typeof body.type === 'number') {
            const momentStart = moment(body.dateStartDate, moment.ISO_8601);
            if (!momentStart.isValid()) {
                const msg = (momentStart.invalidAt() === undefined || momentStart.invalidAt() < 0) ? message.userError.INVALIDDATE : message.dateError[momentStart.invalidAt()];
      Severity: Major
      Found in packages/optimise-core/src/controllers/ceController.js - About 1 hr to fix

        Avoid too many return statements within this function.
        Open

                    return;
        Severity: Major
        Found in packages/optimise-core/src/controllers/ceController.js - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (body.hasOwnProperty('endDate') && body.endDate !== null && !momentEnd.isValid()) {
            const msg = (momentEnd.invalidAt() === undefined || momentEnd.invalidAt() < 0) ? message.userError.INVALIDDATE : message.dateError[momentEnd.invalidAt()];
            res.status(400).json(ErrorHelper(msg, new Error(message.userError.INVALIDDATE)));
            return;
        } else if (body.hasOwnProperty('endDate') && body.endDate !== null) {
          Severity: Major
          Found in packages/optimise-core/src/controllers/ceController.js and 1 other location - About 7 hrs to fix
          packages/optimise-core/src/controllers/ceController.js on lines 62..68

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 185.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (body.hasOwnProperty('dateStartDate') && body.dateStartDate !== null && !momentStart.isValid()) {
            const msg = (momentStart.invalidAt() === undefined || momentStart.invalidAt() < 0) ? message.userError.INVALIDDATE : message.dateError[momentStart.invalidAt()];
            res.status(400).json(ErrorHelper(msg, new Error(message.userError.INVALIDDATE)));
            return;
        } else if (body.hasOwnProperty('dateStartDate') && body.dateStartDate !== null) {
          Severity: Major
          Found in packages/optimise-core/src/controllers/ceController.js and 1 other location - About 7 hrs to fix
          packages/optimise-core/src/controllers/ceController.js on lines 70..76

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 185.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 24 locations. Consider refactoring.
          Open

                      clinicalEventCore.createClinicalEvent(ce).then((result) => {
                res.status(200).json(formatToJSON(result));
                return true;
            }).catch((error) => {
                res.status(400).json(ErrorHelper(message.errorMessages.CREATIONFAIL, error));
          Severity: Major
          Found in packages/optimise-core/src/controllers/ceController.js and 23 other locations - About 3 hrs to fix
          packages/optimise-core/src/controllers/actionController.js on lines 18..24
          packages/optimise-core/src/controllers/comorbidityController.js on lines 20..26
          packages/optimise-core/src/controllers/comorbidityController.js on lines 43..49
          packages/optimise-core/src/controllers/concomitantMedController.js on lines 39..45
          packages/optimise-core/src/controllers/demographicDataController.js on lines 44..50
          packages/optimise-core/src/controllers/demographicDataController.js on lines 69..75
          packages/optimise-core/src/controllers/demographicDataController.js on lines 107..113
          packages/optimise-core/src/controllers/demographicDataController.js on lines 380..386
          packages/optimise-core/src/controllers/demographicDataController.js on lines 426..432
          packages/optimise-core/src/controllers/demographicDataController.js on lines 525..531
          packages/optimise-core/src/controllers/demographicDataController.js on lines 614..620
          packages/optimise-core/src/controllers/patientDiagnosisController.js on lines 44..50
          packages/optimise-core/src/controllers/patientPiiController.js on lines 36..42
          packages/optimise-core/src/controllers/syncController.js on lines 31..37
          packages/optimise-core/src/controllers/syncController.js on lines 55..61
          packages/optimise-core/src/controllers/testController.js on lines 39..45
          packages/optimise-core/src/controllers/treatmentController.js on lines 64..70
          packages/optimise-core/src/controllers/userController.js on lines 58..64
          packages/optimise-core/src/controllers/userController.js on lines 110..116
          packages/optimise-core/src/controllers/userController.js on lines 147..153
          packages/optimise-core/src/controllers/visitController.js on lines 50..56
          packages/optimise-core/src/controllers/visitController.js on lines 112..118
          packages/optimise-core/src/controllers/visitController.js on lines 134..140

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 100.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 4 locations. Consider refactoring.
          Open

                      if (body.hasOwnProperty('meddra') && body.meddra !== null && isNaN(parseInt(body.meddra))) {
                res.status(400).json(ErrorHelper(message.userError.WRONGARGUMENTS));
                return;
            }
          Severity: Major
          Found in packages/optimise-core/src/controllers/ceController.js and 3 other locations - About 2 hrs to fix
          packages/optimise-core/src/controllers/demographicDataController.js on lines 392..395
          packages/optimise-core/src/controllers/treatmentController.js on lines 170..173
          packages/optimise-core/src/controllers/treatmentController.js on lines 213..216

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 75.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 9 locations. Consider refactoring.
          Open

                  if (!body.hasOwnProperty('id')) {
            res.status(400).json(ErrorHelper(message.userError.MISSINGARGUMENT));
            return;
        }
          Severity: Major
          Found in packages/optimise-core/src/controllers/ceController.js and 8 other locations - About 40 mins to fix
          packages/optimise-core/src/controllers/comorbidityController.js on lines 8..11
          packages/optimise-core/src/controllers/demographicDataController.js on lines 624..627
          packages/optimise-core/src/controllers/testController.js on lines 49..52
          packages/optimise-core/src/controllers/treatmentController.js on lines 133..136
          packages/optimise-core/src/controllers/userController.js on lines 158..161
          packages/optimise-core/src/controllers/visitController.js on lines 19..22
          packages/optimise-core/src/controllers/visitController.js on lines 62..65
          packages/optimise-core/src/controllers/visitController.js on lines 88..91

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status