Sign upLogin

dsi-icl/optimise

View on GitHub
Star
packages/optimise-core/src/controllers/patientDiagnosisController.js

Summary

Maintainability
F
4 days
Test Coverage

Function createPatientDiagnosis has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    static createPatientDiagnosis({ body, user }, res) {
        const entryObj = {};
        if (body.hasOwnProperty('patient') && body.hasOwnProperty('diagnosis') && body.hasOwnProperty('diagnosisDate') &&
            typeof body.patient === 'number' && typeof body.diagnosis === 'number' && typeof body.diagnosisDate === 'string') {
            const momentDiagnos = moment(body.diagnosisDate, moment.ISO_8601);
Severity: Minor
Found in packages/optimise-core/src/controllers/patientDiagnosisController.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function createPatientDiagnosis has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    static createPatientDiagnosis({ body, user }, res) {
        const entryObj = {};
        if (body.hasOwnProperty('patient') && body.hasOwnProperty('diagnosis') && body.hasOwnProperty('diagnosisDate') &&
            typeof body.patient === 'number' && typeof body.diagnosis === 'number' && typeof body.diagnosisDate === 'string') {
            const momentDiagnos = moment(body.diagnosisDate, moment.ISO_8601);
Severity: Minor
Found in packages/optimise-core/src/controllers/patientDiagnosisController.js - About 1 hr to fix

    Function updatePatientDiagnosis has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        static updatePatientDiagnosis({ body, user }, res) {
        if (body.hasOwnProperty('id') && typeof body.id === 'number') {
            const entryObj = body;
            const momentDiagnos = moment(body.diagnosisDate, moment.ISO_8601);
            if (body.hasOwnProperty('diagnosisDate') && body.diagnosisDate !== null && !momentDiagnos.isValid()) {
    Severity: Minor
    Found in packages/optimise-core/src/controllers/patientDiagnosisController.js - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Consider simplifying this complex logical expression.
    Open

            if (body.hasOwnProperty('patient') && body.hasOwnProperty('diagnosis') && body.hasOwnProperty('diagnosisDate') &&
            typeof body.patient === 'number' && typeof body.diagnosis === 'number' && typeof body.diagnosisDate === 'string') {
            const momentDiagnos = moment(body.diagnosisDate, moment.ISO_8601);
            if (!momentDiagnos.isValid() && body.diagnosisDate !== null) {
                const msg = messages.dateError[momentDiagnos.invalidAt()] !== undefined ? messages.dateError[momentDiagnos.invalidAt()] : messages.userError.INVALIDDATE;
    Severity: Major
    Found in packages/optimise-core/src/controllers/patientDiagnosisController.js - About 40 mins to fix

      Similar blocks of code found in 7 locations. Consider refactoring.
      Open

          static deletePatientDiagnosis({ body, user }, res) {
        if (body.hasOwnProperty('id') && typeof body.id === 'number') {
            PatientDiagnosisCore.deletePatientDiagnosis(user, { id: body.id }).then((result) => {
                res.status(200).json(formatToJSON(result));
                return true;
      Severity: Major
      Found in packages/optimise-core/src/controllers/patientDiagnosisController.js and 6 other locations - About 1 day to fix
      packages/optimise-core/src/controllers/demographicDataController.js on lines 123..139
      packages/optimise-core/src/controllers/demographicDataController.js on lines 141..157
      packages/optimise-core/src/controllers/demographicDataController.js on lines 159..175
      packages/optimise-core/src/controllers/demographicDataController.js on lines 645..662
      packages/optimise-core/src/controllers/patientPiiController.js on lines 72..88
      packages/optimise-core/src/controllers/testController.js on lines 79..96

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 247.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

                  if (body.hasOwnProperty('diagnosisDate') && body.diagnosisDate !== null && !momentDiagnos.isValid()) {
                const msg = messages.dateError[momentDiagnos.invalidAt()] !== undefined ? messages.dateError[momentDiagnos.invalidAt()] : messages.userError.INVALIDDATE;
                res.status(400).json(ErrorHelper(msg, new Error(messages.userError.INVALIDDATE)));
                return;
            } else if (body.hasOwnProperty('diagnosisDate') && body.diagnosisDate !== null) {
      Severity: Major
      Found in packages/optimise-core/src/controllers/patientDiagnosisController.js and 5 other locations - About 7 hrs to fix
      packages/optimise-core/src/controllers/demographicDataController.js on lines 448..454
      packages/optimise-core/src/controllers/demographicDataController.js on lines 455..461
      packages/optimise-core/src/controllers/demographicDataController.js on lines 541..547
      packages/optimise-core/src/controllers/testController.js on lines 55..61
      packages/optimise-core/src/controllers/testController.js on lines 63..69

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 178.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

                  if (!momentDiagnos.isValid() && body.diagnosisDate !== null) {
                const msg = messages.dateError[momentDiagnos.invalidAt()] !== undefined ? messages.dateError[momentDiagnos.invalidAt()] : messages.userError.INVALIDDATE;
                res.status(400).json(ErrorHelper(msg, new Error(messages.userError.INVALIDDATE)));
                return;
            }
      Severity: Major
      Found in packages/optimise-core/src/controllers/patientDiagnosisController.js and 5 other locations - About 4 hrs to fix
      packages/optimise-core/src/controllers/demographicDataController.js on lines 57..61
      packages/optimise-core/src/controllers/demographicDataController.js on lines 90..94
      packages/optimise-core/src/controllers/testController.js on lines 19..23
      packages/optimise-core/src/controllers/treatmentController.js on lines 160..164
      packages/optimise-core/src/controllers/visitController.js on lines 38..42

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 120.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          static getDiagnosisOptions(__unused__req, res) {
        PatientDiagnosisCore.getDiagnosisOptions().then((result) => {
            res.status(200).json(formatToJSON(result));
            return true;
        }).catch((error) => {
      Severity: Major
      Found in packages/optimise-core/src/controllers/patientDiagnosisController.js and 2 other locations - About 3 hrs to fix
      packages/optimise-core/src/controllers/demographicDataController.js on lines 664..672
      packages/optimise-core/src/controllers/demographicDataController.js on lines 674..682

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 109.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

                  PatientDiagnosisCore.updatePatientDiagnosis(user, body.id, entryObj).then((result) => {
                res.status(200).json(formatToJSON(result));
                return true;
            }).catch((error) => {
                res.status(400).json(ErrorHelper(messages.errorMessages.UPDATEFAIL, error));
      Severity: Major
      Found in packages/optimise-core/src/controllers/patientDiagnosisController.js and 3 other locations - About 3 hrs to fix
      packages/optimise-core/src/controllers/patientPiiController.js on lines 56..62
      packages/optimise-core/src/controllers/treatmentController.js on lines 115..121
      packages/optimise-core/src/controllers/treatmentController.js on lines 224..230

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 106.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 24 locations. Consider refactoring.
      Open

                  PatientDiagnosisCore.createPatientDiagnosis(entryObj).then((result) => {
                res.status(200).json(formatToJSON(result));
                return true;
            }).catch((error) => {
                res.status(400).json(ErrorHelper(messages.errorMessages.CREATIONFAIL, error));
      Severity: Major
      Found in packages/optimise-core/src/controllers/patientDiagnosisController.js and 23 other locations - About 3 hrs to fix
      packages/optimise-core/src/controllers/actionController.js on lines 18..24
      packages/optimise-core/src/controllers/ceController.js on lines 39..45
      packages/optimise-core/src/controllers/comorbidityController.js on lines 20..26
      packages/optimise-core/src/controllers/comorbidityController.js on lines 43..49
      packages/optimise-core/src/controllers/concomitantMedController.js on lines 39..45
      packages/optimise-core/src/controllers/demographicDataController.js on lines 44..50
      packages/optimise-core/src/controllers/demographicDataController.js on lines 69..75
      packages/optimise-core/src/controllers/demographicDataController.js on lines 107..113
      packages/optimise-core/src/controllers/demographicDataController.js on lines 380..386
      packages/optimise-core/src/controllers/demographicDataController.js on lines 426..432
      packages/optimise-core/src/controllers/demographicDataController.js on lines 525..531
      packages/optimise-core/src/controllers/demographicDataController.js on lines 614..620
      packages/optimise-core/src/controllers/patientPiiController.js on lines 36..42
      packages/optimise-core/src/controllers/syncController.js on lines 31..37
      packages/optimise-core/src/controllers/syncController.js on lines 55..61
      packages/optimise-core/src/controllers/testController.js on lines 39..45
      packages/optimise-core/src/controllers/treatmentController.js on lines 64..70
      packages/optimise-core/src/controllers/userController.js on lines 58..64
      packages/optimise-core/src/controllers/userController.js on lines 110..116
      packages/optimise-core/src/controllers/userController.js on lines 147..153
      packages/optimise-core/src/controllers/visitController.js on lines 50..56
      packages/optimise-core/src/controllers/visitController.js on lines 112..118
      packages/optimise-core/src/controllers/visitController.js on lines 134..140

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 100.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              if (body.hasOwnProperty('patient') && body.hasOwnProperty('diagnosis') && body.hasOwnProperty('diagnosisDate') &&
            typeof body.patient === 'number' && typeof body.diagnosis === 'number' && typeof body.diagnosisDate === 'string') {
            const momentDiagnos = moment(body.diagnosisDate, moment.ISO_8601);
            if (!momentDiagnos.isValid() && body.diagnosisDate !== null) {
                const msg = messages.dateError[momentDiagnos.invalidAt()] !== undefined ? messages.dateError[momentDiagnos.invalidAt()] : messages.userError.INVALIDDATE;
      Severity: Major
      Found in packages/optimise-core/src/controllers/patientDiagnosisController.js and 2 other locations - About 2 hrs to fix
      packages/optimise-core/src/controllers/demographicDataController.js on lines 54..82
      packages/optimise-core/src/controllers/treatmentController.js on lines 74..95

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 76.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status