Sign upLogin

dsi-icl/optimise

View on GitHub
Star
packages/optimise-core/src/controllers/patientPiiController.js

Summary

Maintainability
D
3 days
Test Coverage

Consider simplifying this complex logical expression.
Open

        if (body.hasOwnProperty('patient') && body.hasOwnProperty('firstName') && body.hasOwnProperty('surname') && body.hasOwnProperty('fullAddress') && body.hasOwnProperty('postcode') &&
            typeof body.patient === 'number' && typeof body.firstName === 'string' && typeof body.surname === 'string' && typeof body.fullAddress === 'string' && typeof body.postcode === 'string') {
            const entryObj = Object.assign({}, PatientPiiModel, body);
            entryObj.createdByUser = user.id;
            PatientPiiCore.createPatientPii(entryObj).then((result) => {
Severity: Critical
Found in packages/optimise-core/src/controllers/patientPiiController.js - About 2 hrs to fix

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

        static deletePatientPii({ body, user }, res) {
        if (body.hasOwnProperty('id') && typeof body.id === 'number') {
            PatientPiiCore.deletePatientPii(user, { id: body.id }).then((result) => {
                res.status(200).json(formatToJSON(result));
                return true;
    Severity: Major
    Found in packages/optimise-core/src/controllers/patientPiiController.js and 6 other locations - About 1 day to fix
    packages/optimise-core/src/controllers/demographicDataController.js on lines 123..139
    packages/optimise-core/src/controllers/demographicDataController.js on lines 141..157
    packages/optimise-core/src/controllers/demographicDataController.js on lines 159..175
    packages/optimise-core/src/controllers/demographicDataController.js on lines 645..662
    packages/optimise-core/src/controllers/patientDiagnosisController.js on lines 87..103
    packages/optimise-core/src/controllers/testController.js on lines 79..96

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 247.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if (body.hasOwnProperty('patient') && body.hasOwnProperty('firstName') && body.hasOwnProperty('surname') && body.hasOwnProperty('fullAddress') && body.hasOwnProperty('postcode') &&
            typeof body.patient === 'number' && typeof body.firstName === 'string' && typeof body.surname === 'string' && typeof body.fullAddress === 'string' && typeof body.postcode === 'string') {
            const entryObj = Object.assign({}, PatientPiiModel, body);
            entryObj.createdByUser = user.id;
            PatientPiiCore.createPatientPii(entryObj).then((result) => {
    Severity: Major
    Found in packages/optimise-core/src/controllers/patientPiiController.js and 1 other location - About 4 hrs to fix
    packages/optimise-core/src/controllers/demographicDataController.js on lines 86..120

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 134.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

                PatientPiiCore.updatePatientPii(user, body.id, entryObj).then((result) => {
                res.status(200).json(formatToJSON(result));
                return true;
            }).catch((error) => {
                res.status(400).json(ErrorHelper(messages.errorMessages.UPDATEFAIL, error));
    Severity: Major
    Found in packages/optimise-core/src/controllers/patientPiiController.js and 3 other locations - About 3 hrs to fix
    packages/optimise-core/src/controllers/patientDiagnosisController.js on lines 71..77
    packages/optimise-core/src/controllers/treatmentController.js on lines 115..121
    packages/optimise-core/src/controllers/treatmentController.js on lines 224..230

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 106.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 24 locations. Consider refactoring.
    Open

                PatientPiiCore.createPatientPii(entryObj).then((result) => {
                res.status(200).json(formatToJSON(result));
                return true;
            }).catch((error) => {
                res.status(400).json(ErrorHelper(messages.errorMessages.CREATIONFAIL, error));
    Severity: Major
    Found in packages/optimise-core/src/controllers/patientPiiController.js and 23 other locations - About 3 hrs to fix
    packages/optimise-core/src/controllers/actionController.js on lines 18..24
    packages/optimise-core/src/controllers/ceController.js on lines 39..45
    packages/optimise-core/src/controllers/comorbidityController.js on lines 20..26
    packages/optimise-core/src/controllers/comorbidityController.js on lines 43..49
    packages/optimise-core/src/controllers/concomitantMedController.js on lines 39..45
    packages/optimise-core/src/controllers/demographicDataController.js on lines 44..50
    packages/optimise-core/src/controllers/demographicDataController.js on lines 69..75
    packages/optimise-core/src/controllers/demographicDataController.js on lines 107..113
    packages/optimise-core/src/controllers/demographicDataController.js on lines 380..386
    packages/optimise-core/src/controllers/demographicDataController.js on lines 426..432
    packages/optimise-core/src/controllers/demographicDataController.js on lines 525..531
    packages/optimise-core/src/controllers/demographicDataController.js on lines 614..620
    packages/optimise-core/src/controllers/patientDiagnosisController.js on lines 44..50
    packages/optimise-core/src/controllers/syncController.js on lines 31..37
    packages/optimise-core/src/controllers/syncController.js on lines 55..61
    packages/optimise-core/src/controllers/testController.js on lines 39..45
    packages/optimise-core/src/controllers/treatmentController.js on lines 64..70
    packages/optimise-core/src/controllers/userController.js on lines 58..64
    packages/optimise-core/src/controllers/userController.js on lines 110..116
    packages/optimise-core/src/controllers/userController.js on lines 147..153
    packages/optimise-core/src/controllers/visitController.js on lines 50..56
    packages/optimise-core/src/controllers/visitController.js on lines 112..118
    packages/optimise-core/src/controllers/visitController.js on lines 134..140

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 100.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status