Sign upLogin

dsi-icl/optimise

View on GitHub
Star
packages/optimise-core/src/db/patient_pii.table.js

Summary

Maintainability
B
6 hrs
Test Coverage

Similar blocks of code found in 24 locations. Consider refactoring.
Open

        case 18:
            await dbcon().schema.table(TABLE_NAME, (table) => {
                table.dropForeign('patient');
                table.foreign('patient').references('id').inTable('PATIENTS').onDelete('CASCADE');
            });
Severity: Major
Found in packages/optimise-core/src/db/patient_pii.table.js and 23 other locations - About 2 hrs to fix
packages/optimise-core/src/db/clinical_events.table.js on lines 25..30
packages/optimise-core/src/db/clinical_events.table.js on lines 31..36
packages/optimise-core/src/db/clinical_events.table.js on lines 37..42
packages/optimise-core/src/db/medical_history.table.js on lines 26..31
packages/optimise-core/src/db/medical_history.table.js on lines 32..37
packages/optimise-core/src/db/medical_history.table.js on lines 38..43
packages/optimise-core/src/db/patient_demographic.table.js on lines 69..74
packages/optimise-core/src/db/patient_demographic.table.js on lines 75..80
packages/optimise-core/src/db/patient_demographic.table.js on lines 81..86
packages/optimise-core/src/db/patient_diagnosis.table.js on lines 23..28
packages/optimise-core/src/db/patient_diagnosis.table.js on lines 29..34
packages/optimise-core/src/db/patient_diagnosis.table.js on lines 35..40
packages/optimise-core/src/db/patient_immunisation.table.js on lines 23..28
packages/optimise-core/src/db/patient_immunisation.table.js on lines 29..34
packages/optimise-core/src/db/patient_immunisation.table.js on lines 35..40
packages/optimise-core/src/db/patient_pii.table.js on lines 25..30
packages/optimise-core/src/db/patient_pii.table.js on lines 31..36
packages/optimise-core/src/db/patient_pregnancy.table.js on lines 25..30
packages/optimise-core/src/db/patient_pregnancy.table.js on lines 31..36
packages/optimise-core/src/db/patient_pregnancy.table.js on lines 37..42
packages/optimise-core/src/db/visits.table.js on lines 23..28
packages/optimise-core/src/db/visits.table.js on lines 29..34
packages/optimise-core/src/db/visits.table.js on lines 35..40

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 24 locations. Consider refactoring.
Open

        case 16:
            await dbcon().schema.table(TABLE_NAME, (table) => {
                table.dropForeign('patient');
                table.foreign('patient').references('id').inTable('PATIENTS').onDelete('CASCADE');
            });
Severity: Major
Found in packages/optimise-core/src/db/patient_pii.table.js and 23 other locations - About 2 hrs to fix
packages/optimise-core/src/db/clinical_events.table.js on lines 25..30
packages/optimise-core/src/db/clinical_events.table.js on lines 31..36
packages/optimise-core/src/db/clinical_events.table.js on lines 37..42
packages/optimise-core/src/db/medical_history.table.js on lines 26..31
packages/optimise-core/src/db/medical_history.table.js on lines 32..37
packages/optimise-core/src/db/medical_history.table.js on lines 38..43
packages/optimise-core/src/db/patient_demographic.table.js on lines 69..74
packages/optimise-core/src/db/patient_demographic.table.js on lines 75..80
packages/optimise-core/src/db/patient_demographic.table.js on lines 81..86
packages/optimise-core/src/db/patient_diagnosis.table.js on lines 23..28
packages/optimise-core/src/db/patient_diagnosis.table.js on lines 29..34
packages/optimise-core/src/db/patient_diagnosis.table.js on lines 35..40
packages/optimise-core/src/db/patient_immunisation.table.js on lines 23..28
packages/optimise-core/src/db/patient_immunisation.table.js on lines 29..34
packages/optimise-core/src/db/patient_immunisation.table.js on lines 35..40
packages/optimise-core/src/db/patient_pii.table.js on lines 31..36
packages/optimise-core/src/db/patient_pii.table.js on lines 37..42
packages/optimise-core/src/db/patient_pregnancy.table.js on lines 25..30
packages/optimise-core/src/db/patient_pregnancy.table.js on lines 31..36
packages/optimise-core/src/db/patient_pregnancy.table.js on lines 37..42
packages/optimise-core/src/db/visits.table.js on lines 23..28
packages/optimise-core/src/db/visits.table.js on lines 29..34
packages/optimise-core/src/db/visits.table.js on lines 35..40

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 24 locations. Consider refactoring.
Open

        case 17:
            await dbcon().schema.table(TABLE_NAME, (table) => {
                table.dropForeign('patient');
                table.foreign('patient').references('id').inTable('PATIENTS').onDelete('CASCADE');
            });
Severity: Major
Found in packages/optimise-core/src/db/patient_pii.table.js and 23 other locations - About 2 hrs to fix
packages/optimise-core/src/db/clinical_events.table.js on lines 25..30
packages/optimise-core/src/db/clinical_events.table.js on lines 31..36
packages/optimise-core/src/db/clinical_events.table.js on lines 37..42
packages/optimise-core/src/db/medical_history.table.js on lines 26..31
packages/optimise-core/src/db/medical_history.table.js on lines 32..37
packages/optimise-core/src/db/medical_history.table.js on lines 38..43
packages/optimise-core/src/db/patient_demographic.table.js on lines 69..74
packages/optimise-core/src/db/patient_demographic.table.js on lines 75..80
packages/optimise-core/src/db/patient_demographic.table.js on lines 81..86
packages/optimise-core/src/db/patient_diagnosis.table.js on lines 23..28
packages/optimise-core/src/db/patient_diagnosis.table.js on lines 29..34
packages/optimise-core/src/db/patient_diagnosis.table.js on lines 35..40
packages/optimise-core/src/db/patient_immunisation.table.js on lines 23..28
packages/optimise-core/src/db/patient_immunisation.table.js on lines 29..34
packages/optimise-core/src/db/patient_immunisation.table.js on lines 35..40
packages/optimise-core/src/db/patient_pii.table.js on lines 25..30
packages/optimise-core/src/db/patient_pii.table.js on lines 37..42
packages/optimise-core/src/db/patient_pregnancy.table.js on lines 25..30
packages/optimise-core/src/db/patient_pregnancy.table.js on lines 31..36
packages/optimise-core/src/db/patient_pregnancy.table.js on lines 37..42
packages/optimise-core/src/db/visits.table.js on lines 23..28
packages/optimise-core/src/db/visits.table.js on lines 29..34
packages/optimise-core/src/db/visits.table.js on lines 35..40

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status