dsi-icl/optimise

View on GitHub
packages/optimise-core/src/db/patients.table.js

Summary

Maintainability
D
3 days
Test Coverage

Avoid deeply nested control flow statements.
Open

                        if (oldData[i].deleted === '-' && Boolean(oldData[i].consent) === true) {
                            if (oldData[i].study !== 'optimise')
                                oldData[i].optimiseConsent = oldData[i].study;
                            else
                                oldData[i].optimiseConsent = oldData[i].createTime;
Severity: Major
Found in packages/optimise-core/src/db/patients.table.js - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                            if (oldData[i].optimiseConsent === null) {
                                const recordPointsOld = await dbcon()(OLD_TABLE_NAME).where({
                                    uuid: oldData[i].uuid
                                });
                                const v15Data = await dbcon()(V15_TABLE_NAME)
    Severity: Major
    Found in packages/optimise-core/src/db/patients.table.js - About 45 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      const schema_v16 = (dbcon) => dbcon().schema.createTable(TABLE_NAME, (table) => {
          table.increments('id').primary();
          table.boolean('participation').notNullable().defaultTo(true);
          table.text('uuid').notNullable();
          table.text('aliasId').notNullable();
      Severity: Major
      Found in packages/optimise-core/src/db/patients.table.js and 1 other location - About 1 day to fix
      packages/optimise-core/src/db/patients.table.js on lines 83..93

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 266.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      const schema_v1 = (dbcon) => dbcon().schema.createTable(TABLE_NAME, (table) => {
          table.increments('id').primary();
          table.boolean('consent').notNullable().defaultTo(false);
          table.text('uuid').notNullable();
          table.text('aliasId').notNullable();
      Severity: Major
      Found in packages/optimise-core/src/db/patients.table.js and 1 other location - About 1 day to fix
      packages/optimise-core/src/db/patients.table.js on lines 108..118

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 266.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status