dsi-icl/optimise

View on GitHub
packages/optimise-ui/src/redux/actions/concomitantMed.js

Summary

Maintainability
C
1 day
Test Coverage

Similar blocks of code found in 17 locations. Consider refactoring.
Open

export const createConcomitantMedAPICall = (body) => dispatch => apiHelper('/concomitantMeds', { method: 'POST', body: JSON.stringify(body.data) })
    .then(() => {
        dispatch(getPatientProfileById(body.patientId));
    })
    .catch(err => store.dispatch(addError({ error: err })));
Severity: Major
Found in packages/optimise-ui/src/redux/actions/concomitantMed.js and 16 other locations - About 3 hrs to fix
packages/optimise-ui/src/redux/actions/comorbidities.js on lines 6..10
packages/optimise-ui/src/redux/actions/comorbidities.js on lines 12..16
packages/optimise-ui/src/redux/actions/comorbidities.js on lines 18..22
packages/optimise-ui/src/redux/actions/concomitantMed.js on lines 12..16
packages/optimise-ui/src/redux/actions/concomitantMed.js on lines 18..22
packages/optimise-ui/src/redux/actions/consent.js on lines 6..10
packages/optimise-ui/src/redux/actions/consent.js on lines 12..16
packages/optimise-ui/src/redux/actions/demographicData.js on lines 8..14
packages/optimise-ui/src/redux/actions/demographicData.js on lines 16..22
packages/optimise-ui/src/redux/actions/demographicData.js on lines 24..30
packages/optimise-ui/src/redux/actions/demographicData.js on lines 43..49
packages/optimise-ui/src/redux/actions/demographicData.js on lines 51..57
packages/optimise-ui/src/redux/actions/demographicData.js on lines 110..116
packages/optimise-ui/src/redux/actions/demographicData.js on lines 118..124
packages/optimise-ui/src/redux/actions/demographicData.js on lines 144..150
packages/optimise-ui/src/redux/actions/treatments.js on lines 39..42

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 104.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 17 locations. Consider refactoring.
Open

export const editConcomitantMedAPICall = (body) => dispatch => apiHelper('/concomitantMeds', { method: 'PUT', body: JSON.stringify(body.data) })
    .then(() => {
        dispatch(getPatientProfileById(body.patientId));
    })
    .catch(err => store.dispatch(addError({ error: err })));
Severity: Major
Found in packages/optimise-ui/src/redux/actions/concomitantMed.js and 16 other locations - About 3 hrs to fix
packages/optimise-ui/src/redux/actions/comorbidities.js on lines 6..10
packages/optimise-ui/src/redux/actions/comorbidities.js on lines 12..16
packages/optimise-ui/src/redux/actions/comorbidities.js on lines 18..22
packages/optimise-ui/src/redux/actions/concomitantMed.js on lines 6..10
packages/optimise-ui/src/redux/actions/concomitantMed.js on lines 18..22
packages/optimise-ui/src/redux/actions/consent.js on lines 6..10
packages/optimise-ui/src/redux/actions/consent.js on lines 12..16
packages/optimise-ui/src/redux/actions/demographicData.js on lines 8..14
packages/optimise-ui/src/redux/actions/demographicData.js on lines 16..22
packages/optimise-ui/src/redux/actions/demographicData.js on lines 24..30
packages/optimise-ui/src/redux/actions/demographicData.js on lines 43..49
packages/optimise-ui/src/redux/actions/demographicData.js on lines 51..57
packages/optimise-ui/src/redux/actions/demographicData.js on lines 110..116
packages/optimise-ui/src/redux/actions/demographicData.js on lines 118..124
packages/optimise-ui/src/redux/actions/demographicData.js on lines 144..150
packages/optimise-ui/src/redux/actions/treatments.js on lines 39..42

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 104.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 17 locations. Consider refactoring.
Open

export const deleteConcomitantMedAPICall = (body) => dispatch => apiHelper('/concomitantMeds', { method: 'DELETE', body: JSON.stringify(body.data) })
    .then(() => {
        dispatch(getPatientProfileById(body.patientId));
    })
    .catch(err => store.dispatch(addError({ error: err })));
Severity: Major
Found in packages/optimise-ui/src/redux/actions/concomitantMed.js and 16 other locations - About 3 hrs to fix
packages/optimise-ui/src/redux/actions/comorbidities.js on lines 6..10
packages/optimise-ui/src/redux/actions/comorbidities.js on lines 12..16
packages/optimise-ui/src/redux/actions/comorbidities.js on lines 18..22
packages/optimise-ui/src/redux/actions/concomitantMed.js on lines 6..10
packages/optimise-ui/src/redux/actions/concomitantMed.js on lines 12..16
packages/optimise-ui/src/redux/actions/consent.js on lines 6..10
packages/optimise-ui/src/redux/actions/consent.js on lines 12..16
packages/optimise-ui/src/redux/actions/demographicData.js on lines 8..14
packages/optimise-ui/src/redux/actions/demographicData.js on lines 16..22
packages/optimise-ui/src/redux/actions/demographicData.js on lines 24..30
packages/optimise-ui/src/redux/actions/demographicData.js on lines 43..49
packages/optimise-ui/src/redux/actions/demographicData.js on lines 51..57
packages/optimise-ui/src/redux/actions/demographicData.js on lines 110..116
packages/optimise-ui/src/redux/actions/demographicData.js on lines 118..124
packages/optimise-ui/src/redux/actions/demographicData.js on lines 144..150
packages/optimise-ui/src/redux/actions/treatments.js on lines 39..42

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 104.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status