Showing 3 of 3 total issues
Method bid has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def bid(itemid, bid)
item = mechanize.get(ITEM_SEARCH_URL + itemid.to_s)
href = item.search(SELLER_ID_LINK).attribute('href').value
seller_id = href.split('/').last
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method parse_end_time has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def parse_end_time
search_path = type == :auction ? END_TIME_PATH : BIN_END_TIME_PATH
time = item_page.search(search_path).text.split(': ')[1]
return nil if time.nil?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method to_hash has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def to_hash
hash = {}
instance_variables.each do |var|
next if var == :@item_page
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"