Sign upLogin

duncanmmacleod/dqsegdb2

View on GitHub
Star

Showing 4 of 7 total issues

Function query_segments has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

def query_segments(
    flag,
    start,
    end,
    host=None,
Severity: Minor
Found in dqsegdb2/query.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File query.py has 267 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
# DQSEGDB2
# Copyright (C) 2018,2020,2022  Duncan Macleod
#
# This program is free software: you can redistribute it and/or modify
Severity: Minor
Found in dqsegdb2/query.py - About 2 hrs to fix

    File api.py has 259 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    # -*- coding: utf-8 -*-
# DQSEGDB2
# Copyright (C) 2018,2020,2022  Duncan Macleod
#
# This program is free software: you can redistribute it and/or modify
    Severity: Minor
    Found in dqsegdb2/api.py - About 2 hrs to fix

      Function test_query_segments has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      def test_query_segments(flag, coalesce, known, active, raw, requests_mock):
    # mock the request
    versions = (1, 2)
    url = "https://dqsegdb.example.com/dq/X1/TEST"
    requests_mock.get(url, json={"version": versions})
      Severity: Minor
      Found in dqsegdb2/tests/test_query.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language