Sign upLogin

dustin-H/bauhaus-ui

View on GitHub
Star
src/actions/auth.js

Summary

Maintainability
D
2 days
Test Coverage

Function loginSubmit has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function loginSubmit() {
  return (dispatch, getState) => {
    dispatch(authLoginSubmit())
    var state = getState()
    superagent
Severity: Minor
Found in src/actions/auth.js - About 1 hr to fix

    Function checkLogin has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function checkLogin(err) {
  return (dispatch, getState) => {
    var state = getState()
    //var a = state.auth.token !== ''
    if (state.auth.token !== '' && state.auth.profile != null && state.auth.profile.firstname !== '' && state.auth.profile.lastname !== '' && state.auth.profile.avatarUrl !== '') {
    Severity: Minor
    Found in src/actions/auth.js - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

                  return dispatch(changePage(pageTypes.LOGIN))
      Severity: Major
      Found in src/actions/auth.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                  return dispatch(loginError())
        Severity: Major
        Found in src/actions/auth.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                    return dispatch(loginError())
          Severity: Major
          Found in src/actions/auth.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                      return dispatch(loginError())
            Severity: Major
            Found in src/actions/auth.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return dispatch(changePage(pageTypes.LOGIN))
              Severity: Major
              Found in src/actions/auth.js - About 30 mins to fix

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                          if (res.body.profile.firstname == null || typeof res.body.profile.firstname !== 'string') {
            console.error('Auth profile.firstname is missing or not a string!')
            return dispatch(changePage(pageTypes.LOGIN))
          }
                Severity: Major
                Found in src/actions/auth.js and 2 other locations - About 1 hr to fix
                src/actions/auth.js on lines 80..83
                src/actions/auth.js on lines 84..87

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 71.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                          if (res.body.profile.lastname == null || typeof res.body.profile.lastname !== 'string') {
            console.error('Auth profile.lastname is missing or not a string!')
            return dispatch(changePage(pageTypes.LOGIN))
          }
                Severity: Major
                Found in src/actions/auth.js and 2 other locations - About 1 hr to fix
                src/actions/auth.js on lines 76..79
                src/actions/auth.js on lines 84..87

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 71.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                          if (res.body.profile.avatarUrl == null || typeof res.body.profile.avatarUrl !== 'string') {
            console.error('Auth profile.avatarUrl is missing or not a string!')
            return dispatch(changePage(pageTypes.LOGIN))
          }
                Severity: Major
                Found in src/actions/auth.js and 2 other locations - About 1 hr to fix
                src/actions/auth.js on lines 76..79
                src/actions/auth.js on lines 80..83

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 71.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                        if (res.body.profile.lastname == null || typeof res.body.profile.lastname !== 'string') {
          console.error('Auth profile.lastname is missing or not a string!')
          return dispatch(loginError())
        }
                Severity: Major
                Found in src/actions/auth.js and 2 other locations - About 1 hr to fix
                src/actions/auth.js on lines 122..125
                src/actions/auth.js on lines 130..133

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 66.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                        if (res.body.profile.avatarUrl == null || typeof res.body.profile.avatarUrl !== 'string') {
          console.error('Auth profile.avatarUrl is missing or not a string!')
          return dispatch(loginError())
        }
                Severity: Major
                Found in src/actions/auth.js and 2 other locations - About 1 hr to fix
                src/actions/auth.js on lines 122..125
                src/actions/auth.js on lines 126..129

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 66.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                        if (res.body.profile.firstname == null || typeof res.body.profile.firstname !== 'string') {
          console.error('Auth profile.firstname is missing or not a string!')
          return dispatch(loginError())
        }
                Severity: Major
                Found in src/actions/auth.js and 2 other locations - About 1 hr to fix
                src/actions/auth.js on lines 126..129
                src/actions/auth.js on lines 130..133

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 66.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                          if (res.body.token == null || typeof res.body.token !== 'string') {
            console.error('Auth token is missing or not a string!')
            return dispatch(changePage(pageTypes.LOGIN))
          }
                Severity: Major
                Found in src/actions/auth.js and 1 other location - About 1 hr to fix
                src/actions/auth.js on lines 72..75

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 63.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                          if (res.body.profile == null || typeof res.body.profile !== 'object') {
            console.error('Auth profile is missing or not an object!')
            return dispatch(changePage(pageTypes.LOGIN))
          }
                Severity: Major
                Found in src/actions/auth.js and 1 other location - About 1 hr to fix
                src/actions/auth.js on lines 68..71

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 63.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if (res.body.token == null || typeof res.body.token !== 'string') {
          console.error('Auth token is missing or not a string!')
          return dispatch(loginError())
        }
                Severity: Major
                Found in src/actions/auth.js and 1 other location - About 1 hr to fix
                src/actions/auth.js on lines 118..121

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 58.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if (res.body.profile == null || typeof res.body.profile !== 'object') {
          console.error('Auth profile is missing or not an object!')
          return dispatch(loginError())
        }
                Severity: Major
                Found in src/actions/auth.js and 1 other location - About 1 hr to fix
                src/actions/auth.js on lines 114..117

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 58.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status