Sign upLogin

dustin-H/bauhaus-ui

View on GitHub
Star
src/reducers/search.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function search has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function search(state = initialState, action) {
  switch (action.type) {
    case types.SEARCH_ACTIVATE:
      var newState = Object.assign({}, state)
      newState.active = true
Severity: Minor
Found in src/reducers/search.js - About 1 hr to fix

    Avoid too many return statements within this function.
    Open

          return newState
    Severity: Major
    Found in src/reducers/search.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return newState
      Severity: Major
      Found in src/reducers/search.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return newState
        Severity: Major
        Found in src/reducers/search.js - About 30 mins to fix

          Similar blocks of code found in 7 locations. Consider refactoring.
          Open

              case types.SEARCH_SET_LOADING:
      var newState = Object.assign({}, state)
      newState.loading = true
      newState.error = false
      return newState
          Severity: Major
          Found in src/reducers/search.js and 6 other locations - About 45 mins to fix
          src/reducers/auth.js on lines 25..29
          src/reducers/auth.js on lines 41..45
          src/reducers/router.js on lines 28..32
          src/reducers/search.js on lines 43..47
          src/reducers/sideBar.js on lines 19..23
          src/reducers/sideBar.js on lines 24..28

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 7 locations. Consider refactoring.
          Open

              case types.SEARCH_SHOW_ERROR:
      var newState = Object.assign({}, state)
      newState.error = true
      newState.loading = false
      return newState
          Severity: Major
          Found in src/reducers/search.js and 6 other locations - About 45 mins to fix
          src/reducers/auth.js on lines 25..29
          src/reducers/auth.js on lines 41..45
          src/reducers/router.js on lines 28..32
          src/reducers/search.js on lines 25..29
          src/reducers/sideBar.js on lines 19..23
          src/reducers/sideBar.js on lines 24..28

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              case types.SEARCH_TOGGLE:
      var newState = Object.assign({}, state)
      newState.active = !newState.active
      return newState
          Severity: Minor
          Found in src/reducers/search.js and 1 other location - About 30 mins to fix
          src/reducers/sideBar.js on lines 29..32

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status