Sign upLogin

dzunk/redis-time-series

View on GitHub
Star

Showing 4 of 7 total issues

Class TimeSeries has 28 methods (exceeds 20 allowed). Consider refactoring.
Open

  class TimeSeries
    extend Client
    extend Forwardable

    class << self
Severity: Minor
Found in lib/redis/time_series.rb - About 3 hrs to fix

    Class Filters has 26 methods (exceeds 20 allowed). Consider refactoring.
    Open

        class Filters
      Equal = Struct.new(:label, :value) do
        self::REGEX = /^[^!]+=[^(]+/

        def self.parse(str)
    Severity: Minor
    Found in lib/redis/time_series/filters.rb - About 3 hrs to fix

      Method parse_hash has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

            def parse_hash(filter_hash)
        return unless filter_hash.is_a? Hash
        filter_hash.map do |label, value|
          case value
          when TrueClass then Present.new(label)
      Severity: Minor
      Found in lib/redis/time_series/filters.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method multi_cmd has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def multi_cmd(cmd_name, range, filter, count, agg, with_labels)
        filters = Filters.new(filter)
        filters.validate!
        cmd(
          cmd_name,
      Severity: Minor
      Found in lib/redis/time_series.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language