Sign upLogin

e-ucm/js-tracker

View on GitHub
Star
plugins/geolocation.js

Summary

Maintainability
D
1 day
Test Coverage

Function Geolocation has 79 lines of code (exceeds 25 allowed). Consider refactoring.
Open

TrackerPlugins.Geolocation = function() {
    this.interfaces = {

        Places:
         function(tracker) {
Severity: Major
Found in plugins/geolocation.js - About 3 hrs to fix

    Function Geolocation has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

    TrackerPlugins.Geolocation = function() {
    this.interfaces = {

        Places:
         function(tracker) {
    Severity: Minor
    Found in plugins/geolocation.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function Places has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

             function(tracker) {
            this.tracker = tracker;

            this.PlaceType = {
                Building: 0,
    Severity: Minor
    Found in plugins/geolocation.js - About 1 hr to fix

      Function Looked has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

                  this.Looked = function(placeId, type, orientation, latitude, longitude) {
      Severity: Minor
      Found in plugins/geolocation.js - About 35 mins to fix

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                    this.Followed = function(placeId, directions, type) {
                if (typeof type === 'undefined') {type = 0;}

                this.tracker.setLocation(location);
        Severity: Major
        Found in plugins/geolocation.js and 3 other locations - About 2 hrs to fix
        src/js-tracker.js on lines 1008..1013
        src/js-tracker.js on lines 1015..1020
        src/js-tracker.js on lines 1046..1051

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 83.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 7 locations. Consider refactoring.
        Open

                    this.Entered = function(placeId, type) {
                if (typeof type === 'undefined') {type = 5;}

                return this.tracker.Trace('entered',this.PlaceType.properties[type],placeId);
            };
        Severity: Major
        Found in plugins/geolocation.js and 6 other locations - About 1 hr to fix
        plugins/geolocation.js on lines 68..72
        src/js-tracker.js on lines 981..985
        src/js-tracker.js on lines 987..991
        src/js-tracker.js on lines 1040..1044
        src/js-tracker.js on lines 1076..1080
        src/js-tracker.js on lines 1082..1086

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 67.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 7 locations. Consider refactoring.
        Open

                    this.Exited = function(placeId, type) {
                if (typeof type === 'undefined') {type = 5;}

                return this.tracker.Trace('exited',this.PlaceType.properties[type],placeId);
            };
        Severity: Major
        Found in plugins/geolocation.js and 6 other locations - About 1 hr to fix
        plugins/geolocation.js on lines 62..66
        src/js-tracker.js on lines 981..985
        src/js-tracker.js on lines 987..991
        src/js-tracker.js on lines 1040..1044
        src/js-tracker.js on lines 1076..1080
        src/js-tracker.js on lines 1082..1086

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 67.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    this.PlaceType = {
                Building: 0,
                GreenZone: 1,
                UrbanArea: 2,
                Water: 3,
        Severity: Minor
        Found in plugins/geolocation.js and 1 other location - About 55 mins to fix
        src/js-tracker.js on lines 998..1006

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 54.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status