Sign upLogin

e-ucm/rage-analytics-backend

View on GitHub
Star
bin/upgrade/transformers/mongo/transformToVersion4.js

Summary

Maintainability
D
2 days
Test Coverage

Function checkAttempts has 113 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function checkAttempts(config, callback) {

    var playersCollection = config.mongodb.db.collection('players');
    var authTokensCollection = config.mongodb.db.collection('authtokens');
Severity: Major
Found in bin/upgrade/transformers/mongo/transformToVersion4.js - About 4 hrs to fix

    File transformToVersion4.js has 304 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 * Copyright 2016 e-UCM (http://www.e-ucm.es/)
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
    Severity: Minor
    Found in bin/upgrade/transformers/mongo/transformToVersion4.js - About 3 hrs to fix

      Function upgradeAttempts has 82 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function upgradeAttempts(config, callback) {
    // Transformers
    var playersCollection = config.mongodb.db.collection('players');
    var authTokensCollection = config.mongodb.db.collection('authtokens');
      Severity: Major
      Found in bin/upgrade/transformers/mongo/transformToVersion4.js - About 3 hrs to fix

        Function checkGameplay has 66 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            var checkGameplay = function(gameplay, callback) {
        // Check new player fields
        var err = null;
        if (!gameplay.playerName) {
            err = 'A gameplay does not contain its player name.';
        Severity: Major
        Found in bin/upgrade/transformers/mongo/transformToVersion4.js - About 2 hrs to fix

          Function upgrade has 46 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function upgrade(config, callback) {
    // Transformers
    var gamesCollection = config.mongodb.db.collection('games');
    var classesCollection = config.mongodb.db.collection('classes');
    var activitiesCollection = config.mongodb.db.collection('activities');
          Severity: Minor
          Found in bin/upgrade/transformers/mongo/transformToVersion4.js - About 1 hr to fix

            Function updateGameplay has 36 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                var updateGameplay = function(versionId, gameplaysCollection, gameplay, callback) {
        playersCollection.findOneAndUpdate({ _id: gameplay.playerId }, { $addToSet: { versions: versionId }}).then(function(res) {
            playersCollection.findOne({ _id: gameplay.playerId }).then(function(player) {
                gameplay.playerName = player.name;
                gameplay.playerType = player.type;
            Severity: Minor
            Found in bin/upgrade/transformers/mongo/transformToVersion4.js - About 1 hr to fix

              Function check has 31 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function check(config, callback) {
    config.mongodb.db.db.listCollections().toArray(function (err, collections) {
        if (err) {
            console.log('Unexpected error while checking collections names!', err);
            return callback(err, config);
              Severity: Minor
              Found in bin/upgrade/transformers/mongo/transformToVersion4.js - About 1 hr to fix

                Function checkAttempts has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                function checkAttempts(config, callback) {

    var playersCollection = config.mongodb.db.collection('players');
    var authTokensCollection = config.mongodb.db.collection('authtokens');
                Severity: Minor
                Found in bin/upgrade/transformers/mongo/transformToVersion4.js - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                module.exports = {
    backup: backup,
    upgrade: upgrade,
    check: check,
    clean: clean,
                Severity: Major
                Found in bin/upgrade/transformers/mongo/transformToVersion4.js and 2 other locations - About 1 hr to fix
                bin/upgrade/transformers/mongo/transformToVersion2.js on lines 131..142
                bin/upgrade/transformers/mongo/transformToVersion3.js on lines 142..153

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 61.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status