Sign upLogin

e-ucm/rage-analytics-backend

View on GitHub
Star
lib/offlinetraces.js

Summary

Maintainability
F
5 days
Test Coverage

Function exports has 308 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function () {

    var collector = require('./collector');
    var csvToXapi = require('./csvToXAPI');
    var Q = require('q');
Severity: Major
Found in lib/offlinetraces.js - About 1 day to fix

    Function exports has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
    Open

    module.exports = function () {

    var collector = require('./collector');
    var csvToXapi = require('./csvToXAPI');
    var Q = require('q');
    Severity: Minor
    Found in lib/offlinetraces.js - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function createOfflinetraces has 104 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        offlinetraces.createOfflinetraces = function (activityId, username, req, res, kahoot) {
        activityId = offlinetraces.toObjectID(activityId);
        var nofileMessage = '';
        var trackingCode = '';
        // 1 - Check if anactivity exists for the given activityId
    Severity: Major
    Found in lib/offlinetraces.js - About 4 hrs to fix

      Function kahootToCSV has 91 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function kahootToCSV(file) {
        try {
            var buf = fs.readFileSync(file);
            var wb = XLSX.read(buf, {type: 'buffer'});
            var sheets = wb.SheetNames;
      Severity: Major
      Found in lib/offlinetraces.js - About 3 hrs to fix

        File offlinetraces.js has 311 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        'use strict';

module.exports = function () {

    var collector = require('./collector');
        Severity: Minor
        Found in lib/offlinetraces.js - About 3 hrs to fix

          Function sendTraces has 49 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                          var sendTraces = function* () {
                    // This is a * function that can be used with 'yield' to make it synchronous
                    var isTest = (process.env.NODE_ENV === 'test');
                    if (isTest) {
                        return {
          Severity: Minor
          Found in lib/offlinetraces.js - About 1 hr to fix

            Function createOfflinetraces has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                offlinetraces.createOfflinetraces = function (activityId, username, req, res, kahoot) {
            Severity: Minor
            Found in lib/offlinetraces.js - About 35 mins to fix

              Avoid too many return statements within this function.
              Open

                          return csvtraces;
              Severity: Major
              Found in lib/offlinetraces.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                                        return {
                            error: 'No score cell (G' + playerId + ') value found on sheet ' + question
                        };
                Severity: Major
                Found in lib/offlinetraces.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                              return {
                error: 'Unexpected error: ' + err.toString()
            };
                  Severity: Major
                  Found in lib/offlinetraces.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                            return {
                            error: 'No response cell (D' + playerId + ') value found on sheet ' + question
                        };
                    Severity: Major
                    Found in lib/offlinetraces.js - About 30 mins to fix

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                              destination: function (req, file, cb) {
            var pathDir = './offlinetraceskahoot/' + req.params.activityId + '/';
            mkdirp(pathDir, function (err) {
                if (err) {
                    console.error(JSON.stringify(err));
                      Severity: Major
                      Found in lib/offlinetraces.js and 2 other locations - About 3 hrs to fix
                      lib/analysis.js on lines 16..26
                      lib/offlinetraces.js on lines 19..29

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 95.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                              destination: function (req, file, cb) {
            var pathDir = './offlinetraces/' + req.params.activityId + '/';
            mkdirp(pathDir, function (err) {
                if (err) {
                    console.error(JSON.stringify(err));
                      Severity: Major
                      Found in lib/offlinetraces.js and 2 other locations - About 3 hrs to fix
                      lib/analysis.js on lines 16..26
                      lib/offlinetraces.js on lines 46..56

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 95.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                              if (kahoot) {
            uploadKahoot(req, res, function (err) {
                if (err) {
                    deferred.reject({
                        message: JSON.stringify(err),
                      Severity: Major
                      Found in lib/offlinetraces.js and 1 other location - About 2 hrs to fix
                      lib/offlinetraces.js on lines 85..96

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 77.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                              } else {
            upload(req, res, function (err) {
                if (err) {
                    deferred.reject({
                        message: JSON.stringify(err),
                      Severity: Major
                      Found in lib/offlinetraces.js and 1 other location - About 2 hrs to fix
                      lib/offlinetraces.js on lines 74..85

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 77.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status