Sign upLogin

e-ucm/rage-analytics-backend

View on GitHub
Star
lib/tracesConverter.js

Summary

Maintainability
D
2 days
Test Coverage

Function getTarget has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

var getTarget = function (statement, trace) {
    var object = statement.object;
    if (object) {
        var objectId = object.id;
        var index;
Severity: Minor
Found in lib/tracesConverter.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function buildXAPIProfile has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

var buildXAPIProfile = function (statement, trace) {
    var eventError = getEvent(statement, trace);
    if (eventError) {
        return eventError;
    }
Severity: Minor
Found in lib/tracesConverter.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getTarget has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var getTarget = function (statement, trace) {
    var object = statement.object;
    if (object) {
        var objectId = object.id;
        var index;
Severity: Minor
Found in lib/tracesConverter.js - About 1 hr to fix

    Function buildXAPIProfile has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var buildXAPIProfile = function (statement, trace) {
    var eventError = getEvent(statement, trace);
    if (eventError) {
        return eventError;
    }
    Severity: Minor
    Found in lib/tracesConverter.js - About 1 hr to fix

      Function getEvent has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

      var getEvent = function (statement, trace) {
    var verb = statement.verb;
    if (verb) {
        var verbId = verb.id;
        if (verbId) {
      Severity: Minor
      Found in lib/tracesConverter.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function parseExtensions has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      var parseExtensions = function (result, container) {
    var extensions = result.extensions;
    if (extensions) {
        container.ext = {};
        for (var key in extensions) {
      Severity: Minor
      Found in lib/tracesConverter.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function toTrace has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      var toTrace = function (statement, trace) {

    var actor = statement.actor;
    if (actor) {
        var name = actor.name;
      Severity: Minor
      Found in lib/tracesConverter.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

                  return buildReturnError('Object definition is missing for statement, ' + statement);
      Severity: Major
      Found in lib/tracesConverter.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return buildReturnError('Object is missing for statement, ' + statement);
        Severity: Major
        Found in lib/tracesConverter.js - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (objectId) {
            if (endsWith(objectId, '/')) {
                return buildReturnError('Object Id cannot end with / for statement, ' + statement);
            }
            index = objectId.lastIndexOf('/');
          Severity: Major
          Found in lib/tracesConverter.js and 1 other location - About 3 hrs to fix
          lib/tracesConverter.js on lines 33..45

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 111.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if (definitionType) {
                if (endsWith(definitionType, '/')) {
                    return buildReturnError('Object definition type cannot end with / for statement, ' + statement);
                }
                index = definitionType.lastIndexOf('/');
          Severity: Major
          Found in lib/tracesConverter.js and 1 other location - About 3 hrs to fix
          lib/tracesConverter.js on lines 16..28

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 111.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status