Sign upLogin

eHealthAfrica/direct-delivery-dashboard

View on GitHub
Star
src/app/planning/schedule/schedule-round.controller.spec.js

Summary

Maintainability
B
4 hrs
Test Coverage

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    it('Should call $modal.open()', function () {
      expect($modal.open).not.toHaveBeenCalled()
      ScheduleRoundCtrl.openImportDialog()
      expect($modal.open).toHaveBeenCalled()
    })
Severity: Major
Found in src/app/planning/schedule/schedule-round.controller.spec.js and 4 other locations - About 1 hr to fix
src/app/planning/schedule/import/schedule-import-dialog.spec.js on lines 131..135
src/app/planning/schedule/import/schedule-import-dialog.spec.js on lines 189..193
src/app/planning/schedule/import/schedule-import-dialog.spec.js on lines 195..199
src/app/planning/schedule/schedule-round.controller.spec.js on lines 140..144

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    it('Should call $modal.open() with expected parameters', function () {
      expect($modal.open).not.toHaveBeenCalled()
      ScheduleRoundCtrl.openImportDialog()
      expect($modal.open).toHaveBeenCalled()
    })
Severity: Major
Found in src/app/planning/schedule/schedule-round.controller.spec.js and 4 other locations - About 1 hr to fix
src/app/planning/schedule/import/schedule-import-dialog.spec.js on lines 131..135
src/app/planning/schedule/import/schedule-import-dialog.spec.js on lines 189..193
src/app/planning/schedule/import/schedule-import-dialog.spec.js on lines 195..199
src/app/planning/schedule/schedule-round.controller.spec.js on lines 134..138

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('Should set ScheduleRoundCtrl.exportForRouting to expected array', function () {
      var exportData = scheduleService.prepareExport(deliveryRound._id, dailyDeliveries)
      expect(ScheduleRoundCtrl.exportForRouting).toEqual(exportData.rows)
    })
Severity: Major
Found in src/app/planning/schedule/schedule-round.controller.spec.js and 1 other location - About 1 hr to fix
src/app/planning/schedule/schedule-round.controller.spec.js on lines 127..130

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('Should match expected array in given order', function () {
      var exportData = scheduleService.prepareExport(deliveryRound._id, dailyDeliveries)
      expect(ScheduleRoundCtrl.exportHeader).toEqual(exportData.headers)
    })
Severity: Major
Found in src/app/planning/schedule/schedule-round.controller.spec.js and 1 other location - About 1 hr to fix
src/app/planning/schedule/schedule-round.controller.spec.js on lines 120..123

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 56.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status