Sign upLogin

ecl1pse/spree_flash_sales

View on GitHub
Star

Showing 3 of 3 total issues

Class Rails has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Rails < Plan
    def deprecated
      puts "Zeus 0.11.0 changed zeus.json. You'll have to rm zeus.json && zeus init."
    end
    alias_method :spec_helper, :deprecated
Severity: Minor
Found in rails_engine_plan.rb - About 2 hrs to fix

    Method spree_flash_sales_load_products has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      def spree_flash_sales_load_products
    @flash_sale                   = Spree::FlashSale.find(params[:id])

    if @flash_sale.saleable_type == "Spree::Taxon"
    Severity: Minor
    Found in app/controllers/spree/base_controller_decorator.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method spree_flash_sales_load_products has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def spree_flash_sales_load_products
    @flash_sale                   = Spree::FlashSale.find(params[:id])

    if @flash_sale.saleable_type == "Spree::Taxon"
    Severity: Minor
    Found in app/controllers/spree/base_controller_decorator.rb - About 1 hr to fix
      Severity
      Category
      Status
      Source
      Language