Sign upLogin

ecoco/magento_profiler

View on GitHub
Star

Showing 84 of 241 total issues

Function getDataCollectors has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function getDataCollectors()
    {
        if ($this->dataCollectors === null) {
            $contextCollector     = Mage::getSingleton('ecocode_profiler/collector_contextDataCollector');
            $this->dataCollectors = [];
Severity: Minor
Found in app/code/community/Ecocode/Profiler/Model/Profiler.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parseController has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    protected function parseController($controller)
    {
        if (is_object($controller)) {
            /** @var Mage_Core_Controller_Varien_Front $controller */
Severity: Minor
Found in app/code/community/Ecocode/Profiler/Model/Collector/RequestDataCollector.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getLoadLoopCalls has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function getLoadLoopCalls()
    {
        $traceHashList = [];

        foreach ($this->getCallLog() as $item) {
Severity: Minor
Found in app/code/community/Ecocode/Profiler/Model/Collector/ModelDataCollector.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function saveAction has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function saveAction()
    {
        $request = $this->getRequest();
        $key     = $request->getParam('key');
        $value   = $request->getParam('value');
Severity: Minor
Found in app/code/community/Ecocode/Profiler/controllers/SettingsController.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language