edgewall/trac

View on GitHub

Showing 1,050 of 1,372 total issues

Function _render_dir has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def _render_dir(self, req, repos, node, rev, order, desc):
Severity: Minor
Found in trac/versioncontrol/web_ui/browser.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                            if parent != parents[0]:
                                thread.append([0, col, line])
                            add_edge(thread, next_revs.index(parent), line + 1)
    Severity: Major
    Found in trac/versioncontrol/web_ui/util.py - About 45 mins to fix

      Function render_property_diff has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def render_property_diff(self, name, old_context, old_props,
      Severity: Minor
      Found in trac/versioncontrol/web_ui/changeset.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if name and name != path_info and 'alias' not in info:
                                    cset_added = tag.code('trac-admin "%s" changeset '
                                                          'added "%s" $REV'
                                                          % (self.env.path,
                                                             pretty_name))
        Severity: Major
        Found in trac/versioncontrol/admin.py - About 45 mins to fix

          Function get_path_links has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def get_path_links(href, reponame, path, rev, order=None, desc=None):
          Severity: Minor
          Found in trac/versioncontrol/web_ui/util.py - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                for line in tolines[j1:j2]:
                                    line = expandtabs(line, tabwidth, '\0\1')
                                    line = escape(line, quotes=False)
                                    line = '<ins>'.join(space_re.sub(htmlify, seg)
                                                        for seg in line.split('\0'))
            Severity: Major
            Found in trac/versioncontrol/diff.py - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                  for line in fromlines[i1:i2]:
                                      yield '-' + line
                              if tag in ('replace', 'insert'):
              Severity: Major
              Found in trac/versioncontrol/diff.py - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                        if 'dir' in changes:
                                            msg = tag_('You should now run %(resync)s to '
                                                       'synchronize Trac with the repository.',
                                                       resync=resync)
                                            add_notice(req, msg)
                Severity: Major
                Found in trac/versioncontrol/admin.py - About 45 mins to fix

                  Function render_property_diff has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      def render_property_diff(self, name, old_node, old_props,
                  Severity: Minor
                  Found in trac/versioncontrol/web_ui/changeset.py - About 45 mins to fix

                    Function unified_diff has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    def unified_diff(fromlines, tolines, context=None, ignore_blank_lines=0,
                    Severity: Minor
                    Found in trac/versioncontrol/diff.py - About 45 mins to fix

                      Function annotate has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                      Open

                          def annotate(self, row, lineno):
                              if lineno > len(self.annotations):
                                  row.append(tag.th())
                                  return
                              rev = self.annotations[lineno-1]
                      Severity: Minor
                      Found in trac/versioncontrol/web_ui/browser.py - About 45 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function _render_file has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          def _render_file(self, req, context, repos, node, rev=None):
                      Severity: Minor
                      Found in trac/versioncontrol/web_ui/browser.py - About 45 mins to fix

                        Function _render_zip has 6 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            def _render_zip(self, req, context, repos, root_node, rev=None):
                        Severity: Minor
                        Found in trac/versioncontrol/web_ui/browser.py - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                              if 'svn:special' in props and data.startswith('link '):
                                                  data = data[5:]
                                                  kwargs['symlink'] = True
                                              if 'svn:executable' in props:
                          Severity: Major
                          Found in trac/versioncontrol/web_ui/util.py - About 45 mins to fix

                            Avoid deeply nested control flow statements.
                            Open

                                                    for chg in c.get_changes():
                                                        resource = c.resource.parent.child('source',
                                                                                           chg[0] or '/',
                                                                                           r.id)
                                                        if 'FILE_VIEW' not in context.perm(resource):
                            Severity: Major
                            Found in trac/versioncontrol/web_ui/changeset.py - About 45 mins to fix

                              Avoid deeply nested control flow statements.
                              Open

                                          if ($('em', cells[3]).length) newTag = "\\";
                              Severity: Major
                              Found in trac/htdocs/js/diff.js - About 45 mins to fix

                                Function get_filtered_hunks has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                def get_filtered_hunks(fromlines, tolines, context=None,
                                Severity: Minor
                                Found in trac/versioncontrol/diff.py - About 45 mins to fix

                                  Avoid deeply nested control flow statements.
                                  Open

                                                          if prev_rev:
                                                              prev_href = req.href.changeset(prev_rev, reponame,
                                                                                             prev_path)
                                                      else:
                                  Severity: Major
                                  Found in trac/versioncontrol/web_ui/changeset.py - About 45 mins to fix

                                    Avoid deeply nested control flow statements.
                                    Open

                                                            if processor != 'comment':
                                                                buf.write(' [...]\n')
                                                            processor = None
                                    Severity: Major
                                    Found in trac/wiki/formatter.py - About 45 mins to fix

                                      Function render_timeline_event has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                                      Open

                                          def render_timeline_event(self, context, field, event):
                                              wiki_page, comment = event[3]
                                              if field == 'url':
                                                  return context.href.wiki(wiki_page.id, version=wiki_page.version)
                                              elif field == 'title':
                                      Severity: Minor
                                      Found in trac/wiki/web_ui.py - About 45 mins to fix

                                      Cognitive Complexity

                                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                      A method's cognitive complexity is based on a few simple rules:

                                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                      • Code is considered more complex for each "break in the linear flow of the code"
                                      • Code is considered more complex when "flow breaking structures are nested"

                                      Further reading

                                      Severity
                                      Category
                                      Status
                                      Source
                                      Language