efcsydney/efcsydney-roster

View on GitHub
client/src/resource/reducer.js

Summary

Maintainability
C
1 day
Test Coverage

Function asyncStatusReducer has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

export const asyncStatusReducer = (state = defaultAsyncState, action) => {
  const { resource, payload, error } = action;
  if (!resource) return state;
  if (!apiMapping[resource.name]) return state;

Severity: Minor
Found in client/src/resource/reducer.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function asyncDataReducer has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

export const asyncDataReducer = (state = defaultAsyncData, action) => {
  const { resource, payload, error } = action;
  if (!resource) return state;
  if (!apiMapping[resource.name]) return state;
  if (resource.stage !== 'complete') return state;
Severity: Minor
Found in client/src/resource/reducer.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function asyncCacheReducer has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

const asyncCacheReducer = (state = {}, action) => {
  const { resource, payload, error } = action;
  if (!resource) return state;
  if (!apiMapping[resource.name]) return state;
  if (resource.method !== 'retrieve') return state;
Severity: Minor
Found in client/src/resource/reducer.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

      return dotDrop.delete(state, [resource.name, payload.params.id]);
Severity: Major
Found in client/src/resource/reducer.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return dotDrop.merge(
              state,
              [resource.name],
              normalized.entities[resource.name]
            );
    Severity: Major
    Found in client/src/resource/reducer.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return state;
      Severity: Major
      Found in client/src/resource/reducer.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return dotDrop.set(state, key, payload);
        Severity: Major
        Found in client/src/resource/reducer.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return state;
          Severity: Major
          Found in client/src/resource/reducer.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return dotDrop.set(state, [resource.name], payload.data);
            Severity: Major
            Found in client/src/resource/reducer.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return state;
              Severity: Major
              Found in client/src/resource/reducer.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return dotDrop.set(state, key, normalized.result);
                Severity: Major
                Found in client/src/resource/reducer.js - About 30 mins to fix

                  There are no issues that match your filters.

                  Category
                  Status