efcsydney/efcsydney-roster

View on GitHub

Showing 17 of 74 total issues

Function renderForm has 145 lines of code (exceeds 100 allowed). Consider refactoring.
Open

  renderForm() {
    const { data } = this.state;
    const { isSaving, hasCompleted } = this.props;
    const name = _.get(data, 'name', '');
    const locale = _.get(data, 'locale', '');
Severity: Major
Found in client/src/modules/admin/services/Popup.js - About 2 hrs to fix

    File Mobile.js has 329 lines of code (exceeds 300 allowed). Consider refactoring.
    Open

    import _ from 'lodash';
    import React, { Component } from 'react';
    import { connect } from 'react-redux';
    import PropTypes from 'prop-types';
    import styled from 'styled-components';
    Severity: Minor
    Found in client/src/modules/index/components/QuarterView/Mobile.js - About 2 hrs to fix

      File utils.js has 306 lines of code (exceeds 300 allowed). Consider refactoring.
      Open

      const { mjml2html } = require('mjml');
      const _ = require('lodash');
      const moment = require('moment');
      const nodemailer = require('nodemailer');
      const log = require('../../api/utilities/logger');
      Severity: Minor
      Found in scripts/email/utils.js - About 2 hrs to fix

        Function asyncStatusReducer has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

        export const asyncStatusReducer = (state = defaultAsyncState, action) => {
          const { resource, payload, error } = action;
          if (!resource) return state;
          if (!apiMapping[resource.name]) return state;
        
        
        Severity: Minor
        Found in client/src/resource/reducer.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function asyncDataReducer has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

        export const asyncDataReducer = (state = defaultAsyncData, action) => {
          const { resource, payload, error } = action;
          if (!resource) return state;
          if (!apiMapping[resource.name]) return state;
          if (resource.stage !== 'complete') return state;
        Severity: Minor
        Found in client/src/resource/reducer.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function asyncCacheReducer has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

        const asyncCacheReducer = (state = {}, action) => {
          const { resource, payload, error } = action;
          if (!resource) return state;
          if (!apiMapping[resource.name]) return state;
          if (resource.method !== 'retrieve') return state;
        Severity: Minor
        Found in client/src/resource/reducer.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function renderMemberRow has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        const renderMemberRow = ({ date, serviceInfo, positions, lang }) => {
          moment.locale(lang);
          if (lang === 'zh-TW') {
            date = moment(date).format('MMMDo');
          } else if (lang === 'en-AU') {
        Severity: Minor
        Found in scripts/email/utils.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function createApi has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        export function createApi(path, overwrite) {
          if (!path) {
            throw new Error('You have to provide the path argument');
          }
        
        
        Severity: Minor
        Found in client/src/apis/utils.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this function.
        Open

                return state;
        Severity: Major
        Found in client/src/resource/reducer.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return state;
          Severity: Major
          Found in client/src/resource/reducer.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return dotDrop.set(state, key, normalized.result);
            Severity: Major
            Found in client/src/resource/reducer.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return 'Connect';
              Severity: Major
              Found in client/src/modules/admin/changelogs/Container.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return dotDrop.merge(
                          state,
                          [resource.name],
                          normalized.entities[resource.name]
                        );
                Severity: Major
                Found in client/src/resource/reducer.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return dotDrop.set(state, key, payload);
                  Severity: Major
                  Found in client/src/resource/reducer.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                            return dotDrop.set(state, [resource.name], payload.data);
                    Severity: Major
                    Found in client/src/resource/reducer.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                            return dotDrop.delete(state, [resource.name, payload.params.id]);
                      Severity: Major
                      Found in client/src/resource/reducer.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                              return state;
                        Severity: Major
                        Found in client/src/resource/reducer.js - About 30 mins to fix
                          Severity
                          Category
                          Status
                          Source
                          Language