Sign upLogin

eisen-dev/eisen_engine

View on GitHub
Star

Showing 10 of 44 total issues

Function get_installed_package has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
Open

def get_installed_package(target_host_ip, command, target_host_os):
    delete_user_machine_packages(target_host_ip)
    a= AnsibleV1Inv.get_inv()
    packages = RunTask(target_host_ip, command,"shell",a)
    if target_host_os == 'Ubuntu':
Severity: Minor
Found in core/PackageListUpdate.py - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File PackageListUpdate.py has 337 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# coding=utf-8
# (c) 2015, Alice Ferrazzi <alice.ferrazzi@gmail.com>
#
# This file is part of Eisen
#
Severity: Minor
Found in core/PackageListUpdate.py - About 4 hrs to fix

    Function get_all_package has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

    def get_all_package(target_host_ip, command, target_host_os):
    delete_repository_package_db(target_host_ip)
    a= AnsibleV1Inv.get_inv()
    packages = RunTask(target_host_ip, command,"shell",a)
    if target_host_os == 'Ubuntu':
    Severity: Minor
    Found in core/PackageListUpdate.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function package_update has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    def package_update(targetHost, os, command):
    if os == 'Raspbian':
        os = 'Ubuntu'
    print (
        '\n------------------------------------' + targetHost
    Severity: Minor
    Found in core/PackageListUpdate.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function PackageAction has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def PackageAction(module, hosts, command, mod, id, pack):
    Severity: Minor
    Found in core/dispatcher.py - About 45 mins to fix

      Function sendTaskToDb has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def sendTaskToDb(engine, metadata, connection, task, target_host):
      Severity: Minor
      Found in core/mysql_config.py - About 35 mins to fix

        Function RunTask has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def RunTask(module, hosts, command, mod, id):
        Severity: Minor
        Found in core/dispatcher.py - About 35 mins to fix

          Function update_repository_package_db has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def update_repository_package_db(package_name,package_version,package_summary,
          Severity: Minor
          Found in core/PackageListUpdate.py - About 35 mins to fix

            Function update_installed_package_db has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def update_installed_package_db(package_name,package_version,package_summary,
            Severity: Minor
            Found in core/PackageListUpdate.py - About 35 mins to fix

              Function search has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              def search(values, searchFor):
    founds = []
    for k in values:
        for v in values[k]:
            if searchFor in v:
              Severity: Minor
              Found in core/AnsibleV1Wrap.py - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language