Sign upLogin

elevenetc/device-manager-back-end

View on GitHub
Star
src/utils/utils.js

Summary

Maintainability
D
1 day
Test Coverage

Function filterDevices has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

function filterDevices(devices, rawFilters) {

    if (!utils.isDefined(rawFilters)) return devices;

    rawFilters = rawFilters.replace(/ /g, '');
Severity: Minor
Found in src/utils/utils.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function fixNumericFilter has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

function fixNumericFilter(filter) {

    if (!utils.isDefined(filter)) return '';
    if (filter.length === 0) return '';
Severity: Minor
Found in src/utils/utils.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function 'filterDevices' has a complexity of 12.
Open

function filterDevices(devices, rawFilters) {
Severity: Minor
Found in src/utils/utils.js by eslint

Limit Cyclomatic Complexity (complexity)

Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

function a(x) {
    if (true) {
        return x; // 1st path
    } else if (false) {
        return x+1; // 2nd path
    } else {
        return 4; // 3rd path
    }
}

Rule Details

This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

Examples of incorrect code for a maximum of 2:

/*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else if (false) {
        return x+1;
    } else {
        return 4; // 3rd path
    }
}

Examples of correct code for a maximum of 2:

/*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else {
        return 4;
    }
}

Options

Optionally, you may specify a max object property:

"complexity": ["error", 2]

is equivalent to

"complexity": ["error", { "max": 2 }]

Deprecated: the object property maximum is deprecated. Please use the property max instead.

When Not To Use It

If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

Further Reading

Related Rules

  • [max-depth](max-depth.md)
  • [max-len](max-len.md)
  • [max-nested-callbacks](max-nested-callbacks.md)
  • [max-params](max-params.md)
  • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

Function 'fixNumericFilter' has a complexity of 8.
Open

function fixNumericFilter(filter) {
Severity: Minor
Found in src/utils/utils.js by eslint

Limit Cyclomatic Complexity (complexity)

Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

function a(x) {
    if (true) {
        return x; // 1st path
    } else if (false) {
        return x+1; // 2nd path
    } else {
        return 4; // 3rd path
    }
}

Rule Details

This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

Examples of incorrect code for a maximum of 2:

/*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else if (false) {
        return x+1;
    } else {
        return 4; // 3rd path
    }
}

Examples of correct code for a maximum of 2:

/*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else {
        return 4;
    }
}

Options

Optionally, you may specify a max object property:

"complexity": ["error", 2]

is equivalent to

"complexity": ["error", { "max": 2 }]

Deprecated: the object property maximum is deprecated. Please use the property max instead.

When Not To Use It

If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

Further Reading

Related Rules

  • [max-depth](max-depth.md)
  • [max-len](max-len.md)
  • [max-nested-callbacks](max-nested-callbacks.md)
  • [max-params](max-params.md)
  • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

Function filterDevices has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function filterDevices(devices, rawFilters) {

    if (!utils.isDefined(rawFilters)) return devices;

    rawFilters = rawFilters.replace(/ /g, '');
Severity: Minor
Found in src/utils/utils.js - About 1 hr to fix

    Function fixNumericFilter has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function fixNumericFilter(filter) {

    if (!utils.isDefined(filter)) return '';
    if (filter.length === 0) return '';
    Severity: Minor
    Found in src/utils/utils.js - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

          if (!this.isDefined(device)) {
        return false;
    } else {
        return this.isPropDefined(device, 'deviceId') &&
            this.isPropDefined(device, 'pushToken') &&
      Severity: Major
      Found in src/utils/utils.js - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                        if(devValue.indexOf(queryValue) === -1 && queryValue.indexOf(devValue) === -1){
                    devices.splice(d, 1);
                }
        Severity: Major
        Found in src/utils/utils.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                      } else if (numericFieldsMap.hasOwnProperty(fKey)) {
                const devKey = numericFieldsMap[fKey];

                if (!isNumericFilterMatch(device[devKey], fValue)) {
                    devices.splice(d, 1);
          Severity: Major
          Found in src/utils/utils.js - About 45 mins to fix

            Avoid too many return statements within this function.
            Open

                                return '=' + filter;
            Severity: Major
            Found in src/utils/utils.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return value < filterValue;
              Severity: Major
              Found in src/utils/utils.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return false;
                Severity: Major
                Found in src/utils/utils.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                      return filter;
                  Severity: Major
                  Found in src/utils/utils.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                        return '';
                    Severity: Major
                    Found in src/utils/utils.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                          return '';
                      Severity: Major
                      Found in src/utils/utils.js - About 30 mins to fix

                        Function isNumericFilterMatch has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                        function isNumericFilterMatch(value, filter) {

    if (!utils.isNumber(value)) return false;

    filter = fixNumericFilter(filter);
                        Severity: Minor
                        Found in src/utils/utils.js - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        TODO found
                        Open

                            //TODO: add negative values support
                        Severity: Minor
                        Found in src/utils/utils.js by fixme

                        TODO found
                        Open

                            //TODO: add support >= and <=
                        Severity: Minor
                        Found in src/utils/utils.js by fixme

                        There are no issues that match your filters.

                        Category
                        Status