Sign upLogin

eliace/ergo-js

View on GitHub
Star
js/core/core-classes.js

Summary

Maintainability
C
1 day
Test Coverage

Function extend has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    E.extend = function(p_ctor, ctor, overrides) {

        var c = ctor;

        if(typeof c == 'object') {
Severity: Minor
Found in js/core/core-classes.js - About 1 hr to fix

    Function defineClass has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        E.defineClass = function(class_name, overrides, etype) {

        var base_class;

        // `extends` class property
    Severity: Minor
    Found in js/core/core-classes.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          E.hasSetter = function(obj, i) {

        var desc = Object.getOwnPropertyDescriptor(obj, i);
        if(desc && desc.set)
            return desc;
      Severity: Major
      Found in js/core/core-classes.js and 1 other location - About 4 hrs to fix
      js/core/core-classes.js on lines 109..123

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 116.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          E.hasGetter = function(obj, i) {

        var desc = Object.getOwnPropertyDescriptor(obj, i);
        if(desc && desc.get)
            return desc;
      Severity: Major
      Found in js/core/core-classes.js and 1 other location - About 4 hrs to fix
      js/core/core-classes.js on lines 125..139

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 116.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status