Sign upLogin

eliace/ergo-js

View on GitHub
Star
js/core/core-def.js

Summary

Maintainability
F
6 days
Test Coverage

Function Ergo has a Cognitive Complexity of 163 (exceeds 5 allowed). Consider refactoring.
Open

var Ergo = (function(){

    var E = {};
Severity: Minor
Found in js/core/core-def.js - About 3 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function Ergo has 216 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var Ergo = (function(){

    var E = {};
Severity: Major
Found in js/core/core-def.js - About 1 day to fix

    Function mergeOptions has 63 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        E.mergeOptions = function(o, sources, rules) {

        sources = Array.isArray(sources) ? sources : [sources];

        rules = rules || E.rules;
    Severity: Major
    Found in js/core/core-def.js - About 2 hrs to fix

      Function deepMerge has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          E.deepMerge = function(o) {

        for(var j = 1; j < arguments.length; j++) {

            var srcObj = arguments[j];
      Severity: Minor
      Found in js/core/core-def.js - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                        else if( a && b && b.constructor == Object ) {
                    $ergo.deepMerge(o[name], b);
                }
                else {
                    o[name] = $ergo.deepCopy(b);
        Severity: Major
        Found in js/core/core-def.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                              if( !o[name] ) {
                        o[name] = b;
                    }
                    else if(j[0] == '!') {
                        // переписываем опцию
          Severity: Major
          Found in js/core/core-def.js - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                    if(!(i in o) || (o[i] && o[i].constructor != Object)) o[i] = {};
            Severity: Major
            Found in js/core/core-def.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                  else if( p && p.constructor == Array ) {//$.isArray(p) ){
        //                if(!(i in o) || !$.isArray(o[i])) o[i] = [];
                        if(!(i in o) || (o[i] && o[i].constructor != Array)) o[i] = [];
                        Ergo.deepMerge(o[i], p);
                    }
              Severity: Major
              Found in js/core/core-def.js - About 45 mins to fix

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                                if( desc && (desc.set || desc.get) ) {
                    var desc2 = Object.getOwnPropertyDescriptor(obj, i);
                    if(desc2) {
                        desc2.set = desc2.set || desc.set;
                        desc2.get = desc2.get || desc.get;
                Severity: Major
                Found in js/core/core-def.js and 3 other locations - About 3 hrs to fix
                js/core/core-def.js on lines 22..35
                js/core/core-def.js on lines 105..133
                js/core/core-def.js on lines 317..340

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 97.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                                if(desc && (desc.get || desc.set) ) {
                    var descOrig = Object.getOwnPropertyDescriptor(o, i);
                    if(descOrig) {
                        descOrig.set = desc.set || descOrig.set;
                        descOrig.get = desc.get || descOrig.get;
                Severity: Major
                Found in js/core/core-def.js and 3 other locations - About 3 hrs to fix
                js/core/core-def.js on lines 22..35
                js/core/core-def.js on lines 66..76
                js/core/core-def.js on lines 317..340

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 97.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                                if( desc && (desc.set || desc.get) ) {
                    var desc2 = Object.getOwnPropertyDescriptor(obj, i);
                    if(desc2) {
                        desc2.set = desc2.set || desc.set;
                        desc2.get = desc2.get || desc.get;
                Severity: Major
                Found in js/core/core-def.js and 3 other locations - About 3 hrs to fix
                js/core/core-def.js on lines 22..35
                js/core/core-def.js on lines 66..76
                js/core/core-def.js on lines 105..133

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 97.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                                if( desc && (desc.set || desc.get) ) {
                    var descOrig = Object.getOwnPropertyDescriptor(obj, i);
                    if(descOrig) {
                        descOrig.set = desc.set || descOrig.set;
                        descOrig.get = desc.get || descOrig.get;
                Severity: Major
                Found in js/core/core-def.js and 3 other locations - About 3 hrs to fix
                js/core/core-def.js on lines 66..76
                js/core/core-def.js on lines 105..133
                js/core/core-def.js on lines 317..340

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 97.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status