eliace/ergo-js

View on GitHub
js/core/object.js

Summary

Maintainability
D
2 days
Test Coverage

Function prop has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

  prop: function(i, v, defaultValue) {

    if(arguments.length == 1 || arguments.length == 3) {

      if( this.options.get && (i in this.options.get) ) {
Severity: Minor
Found in js/core/object.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _initialize has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  _initialize: function (opts) {//}, scope) {

    var o = {
    };

Severity: Minor
Found in js/core/object.js - About 1 hr to fix

    Function prop has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      prop: function(i, v, defaultValue) {
    
        if(arguments.length == 1 || arguments.length == 3) {
    
          if( this.options.get && (i in this.options.get) ) {
    Severity: Minor
    Found in js/core/object.js - About 1 hr to fix

      Function _postConstruct has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        _postConstruct: function(o) {
      
          if(this._includes) {
      //      var mods = o.mods.join(' ').split(' ').uniq();
            for(var i = 0; i < this._includes.length; i++) {
      Severity: Minor
      Found in js/core/object.js - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _initialize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        _initialize: function (opts) {//}, scope) {
      
          var o = {
          };
      
      
      Severity: Minor
      Found in js/core/object.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

            return defaultValue;
      Severity: Major
      Found in js/core/object.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return this;
        Severity: Major
        Found in js/core/object.js - About 30 mins to fix

          Function _destroy has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            _destroy: function() {
              //
          
              if(this._includes) {
          //      var mods = o.mods.join(' ').split(' ').uniq();
          Severity: Minor
          Found in js/core/object.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _preConstruct has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            _preConstruct: function (o) {
          
              // динамическое подключение расширений
              if('include' in o) {
          //      this._includes = o.include.join(' ').split(' ').uniq();
          Severity: Minor
          Found in js/core/object.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _construct has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            _construct: function (o) {
          
              if(this._includes) {
          //      var mods = o.mods.join(' ').split(' ').uniq();
                for(var i = 0; i < this._includes.length; i++) {
          Severity: Minor
          Found in js/core/object.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              if('include' in o) {
          //      this._includes = o.include.join(' ').split(' ').uniq();
          
                for(var i = 0; i < this._includes.length; i++) {
                  var inc = Ergo._aliases['includes:'+this._includes[i]];
          Severity: Major
          Found in js/core/object.js and 2 other locations - About 2 hrs to fix
          js/core/object.js on lines 218..225
          js/core/object.js on lines 243..250

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 88.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              if(this._includes) {
          //      var mods = o.mods.join(' ').split(' ').uniq();
                for(var i = 0; i < this._includes.length; i++) {
                  var inc = Ergo._aliases['includes:'+this._includes[i]];
                  if(inc._construct)
          Severity: Major
          Found in js/core/object.js and 2 other locations - About 2 hrs to fix
          js/core/object.js on lines 187..195
          js/core/object.js on lines 243..250

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 88.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              if(this._includes) {
          //      var mods = o.mods.join(' ').split(' ').uniq();
                for(var i = 0; i < this._includes.length; i++) {
                  var inc = Ergo._aliases['includes:'+this._includes[i]];
                  if(inc._postConstruct)
          Severity: Major
          Found in js/core/object.js and 2 other locations - About 2 hrs to fix
          js/core/object.js on lines 187..195
          js/core/object.js on lines 218..225

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 88.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                Ergo.walkPrototypes(this.constructor, function(clazz){
                  if(clazz.defaults == prevDefaults) return;
                  if('defaults' in clazz) $ergo.mergeOptions(o, clazz.defaults);
                  prevDefaults = clazz.defaults;
                });
          Severity: Major
          Found in js/core/object.js and 1 other location - About 1 hr to fix
          js/core/object.js on lines 93..97

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 69.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                Ergo.walkPrototypes(this.constructor, function(clazz){
                  if(clazz.props == prevProps) return;
                  if('props' in clazz) $ergo.deepMerge(p, clazz.props);
                  prevProps = clazz.props;
                });
          Severity: Major
          Found in js/core/object.js and 1 other location - About 1 hr to fix
          js/core/object.js on lines 79..83

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 69.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status