Sign upLogin

eliace/ergo-js

View on GitHub
Star
js/core/widget-list.js

Summary

Maintainability
F
5 days
Test Coverage

Function add has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    add: function(item, i, type) {

//        console.log('add item');

//        var key;
Severity: Minor
Found in js/core/widget-list.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

`` has 26 functions (exceeds 20 allowed). Consider refactoring.
Open

Ergo.defineClass('Ergo.core.Components', /** @lends Ergo.core.Components.prototype */ {

    extends: 'Ergo.core.Array',

//     defaults: {
Severity: Minor
Found in js/core/widget-list.js - About 3 hrs to fix

    File widget-list.js has 279 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    
//= require array
    Severity: Minor
    Found in js/core/widget-list.js - About 2 hrs to fix

      Function add has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          add: function(item, i, type) {

//        console.log('add item');

//        var key;
      Severity: Minor
      Found in js/core/widget-list.js - About 1 hr to fix

        Function stream has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            stream: function(filter, sorter, pager, callback) {

        var c = this._widget; // возможно не лучшее решение, но практичное

        var filter = filter || c.options.filter;
        Severity: Minor
        Found in js/core/widget-list.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function factory has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            factory: function(o, type) {

        var default_opt = this.options.defaultOpt || 'text';
        if($.isString(o)) {
            var v = o;
        Severity: Minor
        Found in js/core/widget-list.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function stream has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            stream: function(filter, sorter, pager, callback) {

        var c = this._widget; // возможно не лучшее решение, но практичное

        var filter = filter || c.options.filter;
        Severity: Minor
        Found in js/core/widget-list.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            stream: function(filter, sorter, pager, callback) {

        var c = this._widget; // возможно не лучшее решение, но практичное

        var filter = filter || c.options.filter;
        Severity: Major
        Found in js/core/widget-list.js and 1 other location - About 1 day to fix
        js/core/widget-list.js on lines 590..630

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 277.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            stream: function(filter, sorter, pager, callback) {

        var c = this._widget; // возможно не лучшее решение, но практичное

        var filter = filter || c.options.filter;
        Severity: Major
        Found in js/core/widget-list.js and 1 other location - About 1 day to fix
        js/core/widget-list.js on lines 305..343

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 277.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            each: function(callback/* filter, sorter*/) {

        // var c = this._widget; // возможно не лучшее решение, но практичное
        //
        // var values = this.src;
        Severity: Major
        Found in js/core/widget-list.js and 1 other location - About 1 hr to fix
        js/core/widget-list.js on lines 544..585

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 65.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            each: function(callback/*, filter, sorter*/) {

        // var c = this._widget; // возможно не лучшее решение, но практичное
        //
        // var values = this._source;
        Severity: Major
        Found in js/core/widget-list.js and 1 other location - About 1 hr to fix
        js/core/widget-list.js on lines 260..301

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 65.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status