Sign upLogin

eliace/ergo-js

View on GitHub
Star
js/core/widget.js

Summary

Maintainability
F
4 days
Test Coverage

File widget.js has 381 lines of code (exceeds 250 allowed). Consider refactoring.
Open


//= require data
//= require states
//= require layout
//= require widget-opts
Severity: Minor
Found in js/core/widget.js - About 5 hrs to fix

    `` has 29 functions (exceeds 20 allowed). Consider refactoring.
    Open

    Ergo.defineClass('Ergo.core.Widget', /** @lends Ergo.core.Widget.prototype */{

    extends: 'Ergo.core.Object',

    mixins: ['observable', 'statable'],
    Severity: Minor
    Found in js/core/widget.js - About 3 hrs to fix

      Function _destroy has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

          _destroy: function(root) {
        Ergo.core.Widget.superclass._destroy.call(this);

        var self = this;
      Severity: Minor
      Found in js/core/widget.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _postConstruct has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

          _postConstruct: function(o) {
//        this._super(o);
        Ergo.core.Widget.superclass._postConstruct.call(this, o);
      Severity: Minor
      Found in js/core/widget.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function prop has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

          prop: function(i, v, defaultValue) {

        if(arguments.length == 1 || arguments.length == 3) {

            if( this.options.get && (i in this.options.get) ) {
      Severity: Minor
      Found in js/core/widget.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _preConstruct has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          _preConstruct: function(o) {
        Ergo.core.Widget.superclass._preConstruct.call(this, o);
//        this._super(o);
      Severity: Minor
      Found in js/core/widget.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function prop has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          prop: function(i, v, defaultValue) {

        if(arguments.length == 1 || arguments.length == 3) {

            if( this.options.get && (i in this.options.get) ) {
      Severity: Minor
      Found in js/core/widget.js - About 1 hr to fix

        Function _destroy has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            _destroy: function(root) {
        Ergo.core.Widget.superclass._destroy.call(this);

        var self = this;
        Severity: Minor
        Found in js/core/widget.js - About 1 hr to fix

          Function _construct has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              _construct: function(o) {
        Ergo.core.Widget.superclass._construct.call(this, o);


        var self = this;
          Severity: Minor
          Found in js/core/widget.js - About 1 hr to fix

            Function _postConstruct has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                _postConstruct: function(o) {
//        this._super(o);
        Ergo.core.Widget.superclass._postConstruct.call(this, o);
            Severity: Minor
            Found in js/core/widget.js - About 1 hr to fix

              Function _construct has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                  _construct: function(o) {
        Ergo.core.Widget.superclass._construct.call(this, o);


        var self = this;
              Severity: Minor
              Found in js/core/widget.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function value has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  get value() {
        var val;
        var o = this.options;

        if(this.data)
              Severity: Minor
              Found in js/core/widget.js - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function value has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  set value(val) {

//        if(this._lock_value_change) return;

        var o = this.options;
              Severity: Minor
              Found in js/core/widget.js - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function ergo has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

              $.fn.ergo = function(o) {
    if(this.length > 0){
        var widget = (this[0]._dom) ? this[0]._dom._widget : undefined;// this.data('ergo-widget');
        if(widget) return widget;
        if(!o) return undefined;
              Severity: Minor
              Found in js/core/widget.js - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this function.
              Open

                          return defaultValue;
              Severity: Major
              Found in js/core/widget.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return this;
                Severity: Major
                Found in js/core/widget.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                  return this.states.is(i);
                  Severity: Major
                  Found in js/core/widget.js - About 30 mins to fix

                    Function rise has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        rise: function(name, e, baseEvent) {
        if(e == null) {
            e = {};
        }
        else if( e instanceof Ergo.core.Event || e.constructor == Object ) {
                    Severity: Minor
                    Found in js/core/widget.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                if(this.events.events['click']) {
                this.dom.events.on('click', function(e) { this.events.fire('click', {}, e); });
            }
                    Severity: Major
                    Found in js/core/widget.js and 1 other location - About 1 hr to fix
                    js/core/widget.js on lines 448..450

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 63.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                if(this.events.events['doubleClick']) {
                this.dom.events.on('dblclick', function(e) { this.events.fire('doubleClick', {}, e); });
            }
                    Severity: Major
                    Found in js/core/widget.js and 1 other location - About 1 hr to fix
                    js/core/widget.js on lines 444..446

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 63.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if('items' in o){
            for(var i = 0; i < o.items.length; i++)
                this.children.add(o.items[i]);

        }
                    Severity: Major
                    Found in js/core/widget.js and 1 other location - About 1 hr to fix
                    js/widgets/panels/tab-panel.js on lines 67..70

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 62.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        get components() {
        if(!this.__cmp) {
            this.__cmp = new Ergo.core.Components(this, {type: 'component'});
        }
        return this.__cmp;
                    Severity: Major
                    Found in js/core/widget.js and 1 other location - About 1 hr to fix
                    js/core/widget.js on lines 699..704

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 58.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        get items() {
        if(!this.__itm) {
            this.__itm = new Ergo.core.Items(this, {type: 'item'});
        }
        return this.__itm;
                    Severity: Major
                    Found in js/core/widget.js and 1 other location - About 1 hr to fix
                    js/core/widget.js on lines 692..697

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 58.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        next: function() {
        if(!this.parent) return null;
        return this.parent.item(this._index+1);
    },
                    Severity: Minor
                    Found in js/core/widget.js and 1 other location - About 40 mins to fix
                    js/core/widget.js on lines 602..605

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 48.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        prev: function() {
        if(!this.parent) return null;
        return this.parent.item(this._index-1);
    },
                    Severity: Minor
                    Found in js/core/widget.js and 1 other location - About 40 mins to fix
                    js/core/widget.js on lines 594..597

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 48.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                        get children() {
        if(!this.__c) {
            this.__c = new Ergo.core.Children(this);
        }
        return this.__c;
                    Severity: Minor
                    Found in js/core/widget.js and 2 other locations - About 35 mins to fix
                    js/core/events.js on lines 377..382
                    js/core/states.js on lines 658..663

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 47.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status