elisei/pagbank-payment-magento

View on GitHub

Showing 68 of 159 total issues

Avoid too many return statements within this function.
Open

                return false;
Severity: Minor
Found in view/base/web/js/validation/custom-credit-card-validation.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return result.slice(-1);
    Severity: Minor
    Found in view/base/web/js/model/credit-card-validation/credit-card-type.js - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return $proceed($existingToken, $payment);
      Severity: Minor
      Found in Plugin/PaymentToken.php - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return resultWrapper(null, true, false);

          Avoid too many return statements within this function.
          Open

                  return resultWrapper(cardType, false, false);

            Function getAvailableInstallments has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getAvailableInstallments($list, $storeId)
                {
                    $minInstallment = $this->configCc->getMinValuelInstallment($storeId) * 100;
            
                    foreach ($list as $key => $allInstallments) {
            Severity: Minor
            Found in Model/Api/ConsultPSInstallments.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function aroundAddButton has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public function aroundAddButton(
                    View $subject,
                    \Closure $proceed,
                    string $buttonId,
                    array $data,
            Severity: Minor
            Found in Plugin/SalesOrderViewButtonPlugin.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function processErrors has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function processErrors(ResultInterface $result)
                {
                    $messages = [];
                    $errorsSource = array_merge($result->getErrorCodes(), $result->getFailsDescription());
                    foreach ($errorsSource as $errorCodeOrMessage) {
            Severity: Minor
            Found in Gateway/Command/PaymentCommand.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language