Sign upLogin

emarschner/iconify

View on GitHub
Star

Showing 4 of 4 total issues

Function load has 94 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Main.load = function (svg, options) {
  options = $.extend({}, Main.load.defaultOptions, options);

  var svgLoad = $.Deferred(),
      finish = $.Deferred(),
Severity: Major
Found in src/core.js - About 3 hrs to fix

    Function exports has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function (argv, opts) {
  var args = require('minimist')(argv.slice(2)),
      sources = args._.slice(0),
      options = iconify.$.extend(true, { transform: null }, opts),
      defaultOptions = iconify.load.defaultOptions;
    Severity: Minor
    Found in src/node/cli.js - About 2 hrs to fix

      Function load has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

      Main.load = function (svg, options) {
  options = $.extend({}, Main.load.defaultOptions, options);

  var svgLoad = $.Deferred(),
      finish = $.Deferred(),
      Severity: Minor
      Found in src/core.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function Main has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      function Main (el) {
  var $el = el instanceof $ ? el : $(el);

  if ($el.hasClass('inline')) {
    return $el;
      Severity: Minor
      Found in src/core.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language