emq/sidekiq-expected_failures

View on GitHub

Showing 4 of 4 total issues

Method registered has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def self.registered(app)
        web_dir = File.expand_path("../../../../web", __FILE__)

        app.helpers do
          def link_to_details(job)
Severity: Minor
Found in lib/sidekiq/expected_failures/web.rb - About 1 hr to fix

    Function backdrop has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      Modal.prototype.backdrop = function (callback) {
        var that    = this
        var animate = this.$element.hasClass('fade') ? 'fade' : ''
    
        if (this.isShown && this.options.backdrop) {
    Severity: Minor
    Found in web/assets/bootstrap.js - About 1 hr to fix

      Function show has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        Modal.prototype.show = function (_relatedTarget) {
          var that = this
          var e    = $.Event('show.bs.modal', { relatedTarget: _relatedTarget })
      
          this.$element.trigger(e)
      Severity: Minor
      Found in web/assets/bootstrap.js - About 1 hr to fix

        Method registered has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

              def self.registered(app)
                web_dir = File.expand_path("../../../../web", __FILE__)
        
                app.helpers do
                  def link_to_details(job)
        Severity: Minor
        Found in lib/sidekiq/expected_failures/web.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language